Repository navigation
fix(formplayer): localize progress bar navigation labels - #932
Merged
Merged
Conversation
Mishael-2584
self-requested a review
September 24, 2026 08:20
Mishael-2584
approved these changes
Sep 24, 2026
Mishael-2584
left a comment
Contributor
There was a problem hiding this comment.
LGTM, good work @Lemeri123
Member
|
Good work done Lemeri-Boy! |
Contributor
Author
|
Thanks @IamLRBA @Mishael-2584 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The progress-bar chevrons now use the same ODE UI locale as the rest of Formplayer.

Short description of what changed
In
FormProgressBar.tsx,useOdeT()reads the active locale fromFormplayerLocaleContextand looks upnav.previousScreen/nav.nextScreen. English fallbacks stay "Previous screen" and "Next screen". Layout, clicks, and disabled states are unchanged. Locale catalog files were not edited.useOdeTre-renders when the locale changes because it callsuseContext(FormplayerLocaleContext).App.tsxputs that provider around the form UI withuiLocalefromparams.locale. A new locale value makes context consumers re-render, soodeT(locale, key, fallback)runs against the matchingen/pt/frcatalog.Type of Change
Component(s) Changed
Testing
Existing English
getByLabelTextchecks still pass because the helper defaults to 'en'. A new case wraps the bar inFormplayerLocaleContext.Provider with 'pt' and asserts Ecrã anterior / Ecrã seguinte (catalog strings, not duplicates). There was no shared i18n test helper; this reuses the same Provider the app already uses.Checklist
Pre-flight checks for changed packages passed (lint / format / tests)
Verification (from formulus-formplayer/):
pnpm run lint
pnpm run format:check
pnpm test run 220 tests, including 6 in FormProgressBar.test.tsx
pnpm run build
Related issue linked, closes fix(formplayer): localize progress bar navigation labels #907