Repository navigation
fix(formulus): patch RNFS reject to stop attachment-download crashes - #747
Merged
Merged
Conversation
Failed downloads called promise.reject(null, …), which NPEs on RN's Kotlin PromiseImpl and kills the app mid-attachment sync. Co-authored-by: Cursor <cursoragent@cursor.com>
drcelsobat
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timeout handling
Fix crash on time-out while downloading attachment data
Description
Failed downloads called promise.reject(null, …), which NPEs on RN's Kotlin PromiseImpl and kills the app mid-attachment sync. This PR fixes this...
Type of Change
Component(s) Affected
Testing
Breaking Changes
If breaking changes, please describe migration steps:
Documentation Updates
Checklist
Thank you for contributing to Open Data Ensemble (ODE)!