Repository navigation
Conversation
Surface credentials only at creation or admin reset so admins can securely hand off a branded, downloadable Formulus configuration.
Register the documented delete endpoint while retaining the legacy route so portal deletes work without breaking older clients.
r0ssing
requested changes
Jul 14, 2026
r0ssing
left a comment
Member
There was a problem hiding this comment.
Looks great! Only comment is about the changes introduced in Synkronus (test + API), which I don't think should be part of this PR? (I can't even see that the new code in the portal even uses that endpoint, but I might've missed that ;-))
Keep the Synkronus API unchanged by routing portal deletions through the existing legacy endpoint.
Member
Author
|
Addressed in b483006. I removed the Synkronus API, handler, and test changes. The portal now uses the existing |
r0ssing
approved these changes
Jul 14, 2026
r0ssing
left a comment
Member
There was a problem hiding this comment.
Looks great! Thanks @najuna-brian !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security
Test plan
go test ./internal/api ./internal/handlersCloses #694