chore(cache): improve invalidation logic - #45
Draft
sidux wants to merge 8 commits into
Draft
Conversation
sidux
force-pushed
the
improve-cache-invalidation
branch
2 times, most recently
from
July 8, 2024 12:27
1df0ed1 to
3dfa67f
Compare
sidux
force-pushed
the
improve-cache-invalidation
branch
from
July 8, 2024 12:56
3dfa67f to
4d8df97
Compare
sidux
force-pushed
the
improve-cache-invalidation
branch
3 times, most recently
from
July 8, 2024 14:55
1f0a28c to
b8729a3
Compare
|
Issued by Coverage Checker: |
sidux
commented
Jul 8, 2024
sidux
commented
Jul 8, 2024
sidux
commented
Jul 8, 2024
sidux
commented
Jul 8, 2024
sidux
commented
Jul 8, 2024
Contributor
Author
There was a problem hiding this comment.
is there a possible embedded requests edge case ?
sidux
force-pushed
the
improve-cache-invalidation
branch
from
July 8, 2024 15:10
b8729a3 to
2d77187
Compare
Merge current master and retain cache configuration and reserved-character handling. Track visited objects to handle cycles and collect all tags from objects sharing identifiers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic cache tags include the property or method name, with optional explicit prefixes. Cache reads and invalidations use the same tag builder. Cache misses and hits expose their keys and tags for diagnostics.
The current cache configuration and reserved-character sanitization are preserved. Traversal tracks object identity, so cyclic graphs terminate and objects sharing an identifier still contribute their other tags and children. Regression tests verify invalidation through the real Symfony tag-aware cache adapter.
Validation: Composer validation, ECS, PHPStan, and all 82 tests (308 assertions) pass. The repository's existing Nix inputs required temporary local overrides for validation; those overrides are not included in this PR.
Remaining rollout work: