Repository navigation
feat(dpapi): add secret store with import for dpapi (#1) - #245
Draft
Stephanya Casanova (savacano28) wants to merge 2 commits into
Draft
Stephanya Casanova (savacano28) wants to merge 2 commits into
Stephanya Casanova (savacano28) wants to merge 2 commits into
Conversation
Stephanya Casanova (savacano28)
force-pushed
the
sca/secret-store-with-import
branch
from
October 16, 2026 09:52
6d504e8 to
cf33e56
Compare
Stephanya Casanova (savacano28)
changed the base branch from
main
to
sca/agent-secret-store
October 18, 2026 15:47
Stephanya Casanova (savacano28)
added this pull request to stack #247
October 18, 2026 15:51
Stephanya Casanova (savacano28)
force-pushed
the
sca/secret-store-with-import
branch
from
October 18, 2026 16:34
cf33e56 to
aec1665
Compare
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (73.33%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## sca/agent-secret-store #245 +/- ##
==========================================================
+ Coverage 38.91% 45.51% +6.59%
==========================================================
Files 14 16 +2
Lines 740 892 +152
==========================================================
+ Hits 288 406 +118
- Misses 452 486 +34
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
4 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
import(): moves the token into a secret store safely, then deletes the clear-text copies.openaev-agent-token.bootstrap), read before the config.replace_file(): rewrites a file in one step, keeping its ACL / mode.flowchart TD A[Token from bootstrap file<br/>or config] --> B[Write to store] B --> C{Read back OK?} C -- no --> X[Stop, delete nothing<br/>agent uses clear text] C -- yes --> D[Remove token from config] D --> E[Delete bootstrap file]Testing Instructions
openaev-agent-token.bootstrapnext to the exe with a valid token and remove the token from the config: agent stays online.Related issues
Checklist
Further comments
import()is only covered by unit tests until feat(agent): encrypt the token with DPAPI on Windows (#1) #240.toml_edit,windows-sys.