Repository navigation
fix(arbnode): require external sync evidence before reporting synced - #4738
Open
Tyagiquamar wants to merge 1 commit into
Open
Tyagiquamar wants to merge 1 commit into
Tyagiquamar wants to merge 1 commit into
Conversation
Nodes with feed input or a seq coordinator must observe a non-local sync target before SyncMonitor.Synced returns true. Prevents eth_syncing from reporting false on cold-start read-replicas with a warm database. Fixes OffchainLabs#4733
|
|
Author
|
Hi, friendly ping for review on this PR when you have a moment. Happy to address any feedback. Thanks! |
Author
|
Hi, just following up on this when you get a chance. The PR is ready from my side. Happy to address any feedback, including anything on the test setup. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SyncMonitor.Synced()now returns false on cold-start until the node has observed a non-local sync target when feed input or a seq coordinator is configured.seenExternalSyncTargetwhen feed pending message count becomes nonzero, or when the coordinator reports a message count above the local head.feedInputEnabledfromNodestartup based on whether broadcast clients are configured.Fixes #4733.
Test plan
TestSyncMonitorRequiresFeedBeforeReportingSyncedandTestSyncMonitorAllowsLocalSyncWithoutFeedOrCoordinatorinarbnode/sync_monitor_test.gogo test -run TestSyncMonitor ./arbnode/(requires generatedsolgen/go; could not run locally on Windows without Foundry contract build)