Adding mastg, maswe and mobileapp api v2.0 - #3471
Merged
Merged
Conversation
Contributor
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Broad API and deployment changes plus inconsistent OpenAPI examples warrant final human review.
Review details
Suppressed comments (2)
cornucopia.owasp.org/static/api/openapi.yaml:571
- The example is now identified as version 2.0, but its
data/M01payload does not match this endpoint:CreController.getCreMappingreturns astandardsarray, and Mobile App 2.0 card IDs begin with values such asPC2. Please replace the example body with an actual 2.0 response so the newly documented endpoint is usable by consumers.
version: "2.0"
cornucopia.owasp.org/static/api/openapi.yaml:390
- This labels the example as a 2.0 response, but the PC3 payload below is still the 1.1 data (
PLATFORM-3andTEST-0008/TEST-0037/TEST-0057). The 2.0 mapping instead uses numeric MASTG IDs and MASWE fields, so clients copying this example receive a contradictory contract. Either update the payload frommobileapp-mappings-2.0.yamlor keep this example identified as 1.1.
version: "2.0"
- Files reviewed: 15/15 changed files
- Comments generated: 0 new
- Review effort level: Balanced
sydseter
marked this pull request as ready for review
September 8, 2026 15:14
rewtd
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding endpoints for fetching the maswe, mastg, cre, and general mobileapp edition mapping.
AI Tool Disclosure
GitHub CoPilotGPT-5.6 Luna, Thinking level: High, Context size: 200Ksimilar to cornucopia.owasp.org\src\routes\api\asvs\[edition]\[version] and cornucopia.owasp.org\src\routes\api\capec\[edition]\[version] create server.ts controllers for exposing the mobileapp-mastgt-2.0.yaml and the mobileapp-maswe-2.0.yaml mapping. Add relevant swagger documentation and add the endpoints to svelte.config.js , headers-stage.js and headers.js with the headers needed for exposing the application/json api through cloudflare workers. Also make sure the test coverage is 95% and that you follow the linting rules of the cornucopia.owasp.org project. Ensure the api has the same structure as the other api's expect for the necessary changes due to the fact that these expose the maswe and mastg mapping.Affirmation