[Client] Fix closing of shared Transport Channel in Recreate Scenario / Add missing event Handler to Session Constructor / Call RenewUserIdentity on Session.ReCreate - #3055
Merged
Conversation
…he used channel is closed when the Session.Open fails Add Missing Event Handler m_RenewUserIdentity om Session constructor taking a template
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3055 +/- ##
==========================================
+ Coverage 57.00% 57.25% +0.25%
==========================================
Files 357 357
Lines 68916 68983 +67
Branches 14154 14158 +4
==========================================
+ Hits 39285 39496 +211
+ Misses 25385 25244 -141
+ Partials 4246 4243 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Create Async open overload
romanett
marked this pull request as ready for review
May 2, 2025 11:29
mrsuciu
reviewed
May 13, 2025
mrsuciu
approved these changes
May 13, 2025
This was referenced Nov 21, 2025
This was referenced Nov 28, 2025
This was referenced Dec 12, 2025
This was referenced Dec 19, 2025
This was referenced Jan 16, 2026
This was referenced Jan 23, 2026
This was referenced Feb 6, 2026
This was referenced Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Some Session Methods have an overload to share an (expensive) channel between multiple session. However in some reconnect/recreate /fail to Open Session Scenario the shared transport channel is closed by the Open Mehtod of the Session. Therefore this PR Extends the Session.Open Method to select if the used Transport Channel shall be closed.
Also the Session Constructor taking a template missed to copy the m_RenewUserIdentity event handler to the new session
The Session.ReCreate(Async) Methods now also fire the RenewUserIdentity Event before Session.Open is called to refresh an expired user identity token.
Types of changes
Checklist
Further comments