Repository navigation
Conversation
…PiAbs channel in hA
jedori0228
reviewed
Sep 1, 2026
jedori0228
left a comment
Contributor
There was a problem hiding this comment.
I found few places where the merging with develop was done in an opposite way and undo the changes made in develop. That part should be reverted so we keep the structure of develop.
| inline void FSIReweightCalculator::LoadInputHistograms(fhicl::ParameterSet const &ps) { | ||
|
|
||
| std::string const &default_root_file = systtools::expand_env_vars( ps.get<std::string>("input_file", "") ); | ||
| std::string const &default_root_file = ps.get<std::string>("input_file", ""); |
Contributor
There was a problem hiding this comment.
systtools::expand_env_vars should be used to get file path. I think we can "undo" what are done on this function.
| std::string hName = val_config.get<std::string>("name"); | ||
| std::string input_hist = val_config.get<std::string>("input_hist"); | ||
| std::string input_file = systtools::expand_env_vars( val_config.get<std::string>("input_file", default_root_file) ); // If specified per hist, replace it | ||
| std::string input_file = val_config.get<std::string>("input_file", default_root_file); // If specified per hist, replace it |
Contributor
There was a problem hiding this comment.
Same comment as above, we can "undo" what are done on this function.
| inline void FSIReweightCalculatorMult::LoadInputHistograms(fhicl::ParameterSet const &ps) { | ||
|
|
||
| std::string const &default_root_file = systtools::expand_env_vars( ps.get<std::string>("input_file", "") ); | ||
| std::string const &default_root_file = ps.get<std::string>("input_file", ""); |
| std::string hName = val_config.get<std::string>("name"); | ||
| std::string input_hist = val_config.get<std::string>("input_hist"); | ||
| std::string input_file = systtools::expand_env_vars( val_config.get<std::string>("input_file", default_root_file) ); // If specified per hist, replace it | ||
| std::string input_file = val_config.get<std::string>("input_file", default_root_file); // If specified per hist, replace it |
Contributor
There was a problem hiding this comment.
The changes here must be un-done
Contributor
There was a problem hiding this comment.
What are the difference between FSIReweightCalculatorMult.hh and FSIReweightMultCalculator.hh?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed bug that likely broke unitarity.