Skip to content

CPM dotnet add package feature - #4832

Merged
martinrrm merged 2 commits into
devfrom
dev-feature-cpm-dotnetaddpackage
Oct 21, 2022
Merged

martinrrm merged 2 commits into
devfrom
dev-feature-cpm-dotnetaddpackage

Conversation

@martinrrm

Copy link
Copy Markdown
Contributor

Bug

Fixes: NuGet/Home#9022

Regression? Last working version:

Description

This PR merges dotnet add functionality to dev branch

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
    • Test exception
    • OR
    • N/A
  • Documentation

    • Documentation PR or issue filled
    • OR
    • N/A

@martinrrm
martinrrm requested a review from a team as a code owner September 28, 2022 21:04
nkolev92
nkolev92 previously approved these changes Sep 28, 2022
@nkolev92 nkolev92 added the Merge next release PRs that should not be merged until the dev branch targets the next release label Sep 28, 2022
@nkolev92

Copy link
Copy Markdown
Member

As a feature, this should wait on merging until dev switches to 6.5.

@jeffkl
jeffkl self-requested a review October 4, 2022 17:31
@martinrrm
martinrrm force-pushed the dev-feature-cpm-dotnetaddpackage branch from b827f77 to 7eda4b2 Compare October 5, 2022 07:19
@ghost ghost added the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Oct 12, 2022
@ghost

ghost commented Oct 12, 2022

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 7 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch.

@martinrrm
martinrrm force-pushed the dev-feature-cpm-dotnetaddpackage branch from 7eda4b2 to eba10a2 Compare October 12, 2022 16:40
@ghost ghost removed the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Oct 12, 2022
@martinrrm martinrrm removed the Merge next release PRs that should not be merged until the dev branch targets the next release label Oct 12, 2022
@martinrrm
martinrrm force-pushed the dev-feature-cpm-dotnetaddpackage branch from eba10a2 to 36cc894 Compare October 17, 2022 17:39
@erdembayar

Copy link
Copy Markdown
Contributor

As a feature, this should wait on merging until dev switches to 6.5.

Should this merge now since we're on 6.5?

@martinrrm
martinrrm force-pushed the dev-feature-cpm-dotnetaddpackage branch from 3d0a71f to 9ac577b Compare October 19, 2022 23:19
@martinrrm

Copy link
Copy Markdown
Contributor Author

Yess, I've been trying to get a green build so I can finally merge

@martinrrm
martinrrm requested review from a team and nkolev92 October 20, 2022 18:07
@martinrrm

Copy link
Copy Markdown
Contributor Author

Ready to merge, tests were failing because I did a mistake while rebasing

@martinrrm
martinrrm merged commit eb19de0 into dev Oct 21, 2022
@martinrrm
martinrrm deleted the dev-feature-cpm-dotnetaddpackage branch October 21, 2022 17:57
@martinrrm
martinrrm restored the dev-feature-cpm-dotnetaddpackage branch December 14, 2022 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Add support for central package management to dotnet add package

4 participants