Skip to content

Ignore local sources when enforcing package source mapping with central package management - #4764

Merged
jeffkl merged 2 commits into
devfrom
dev-jeffkl-ignore-local-sources-in-cpm-psm-warning
Aug 31, 2022
Merged

jeffkl merged 2 commits into
devfrom
dev-jeffkl-ignore-local-sources-in-cpm-psm-warning

Conversation

@jeffkl

@jeffkl jeffkl commented Aug 19, 2022 •

Copy link
Copy Markdown
Contributor

Bug

Fixes: NuGet/Home#11951

Regression? Last working version:

Description

Trim down configured sources to ones that are not local. Moved the logic inside of the check for package source mapping to avoid the overhead in case the user is already opt-ed in.

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
    • Test exception
    • OR
    • N/A
  • Documentation

    • Documentation PR or issue filled
    • OR
    • N/A

@jeffkl
jeffkl requested a review from a team as a code owner August 19, 2022 18:45
nkolev92
nkolev92 previously approved these changes Aug 29, 2022
@jeffkl
jeffkl force-pushed the dev-jeffkl-ignore-local-sources-in-cpm-psm-warning branch from df56320 to 50f1687 Compare August 30, 2022 15:19
@jeffkl
jeffkl requested a review from nkolev92 August 31, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DCR]: Central package management package source mapping should only look at configured feeds

2 participants