Repository navigation
Revised proposal for Adding dotnet CLI support for projects onboarded to CPM (Take 3) - #11915
Conversation
jeffkl
left a comment
There was a problem hiding this comment.
Thanks for the hard work involved in getting this spec'd out!
nkolev92
left a comment
There was a problem hiding this comment.
Thanks for updating this!
I think the spec still suggests some scenarios are in scope, but realistically only the first 4 are.
| | 1 | ❌ | ❌ | ❌ | ❌ | Add `PackageReference` to the project file. Add `PackageVersion` to the `Directory.Packages.Props` file. Use latest version from the package sources. | ✔️ | | ||
| | 2 | ❌ | ❌ | ❌ | ✔️ | Add `PackageReference` to the project file. Add `PackageVersion` to the `Directory.Packages.Props` file. Use version specified in the commandline. | ✔️ | | ||
| | 3 | ❌ | ❌ | ✔️ | ❌ | Add `PackageReference` to the project file. No changes to the `Directory.Packages.Props` file. Basically we are reusing the version defined centrally for this package. | ✔️ | | ||
| | 4 | ❌ | ❌ | ✔️ | ✔️ | Add `PackageReference` to the project file. Update `PackageVersion` in the `Directory.Packages.Props` file with the version specified in the commandline. | ✔️ | |
There was a problem hiding this comment.
I guess the code path is shared for VS and dotnet.exe. Hence once we address #11912 then it would impact dotnet add package also. Please correct if my understanding is incorrect.
There was a problem hiding this comment.
Not all the code is shared for that actually.
There's a lot of NuGetPackageManager usage in VS.
VS can also update multiple projects at a time.
|
@jeffkl @nkolev92 @kartheekp-ms I have pushed the changes we discussed at our spec review meeting. Please let me know if it all looks good! |
Co-authored-by: Nikolche Kolev <nikolev@microsoft.com>
Tracking issue #11858
Rendered Design Spec
Proposal for 11807
Here is what changed when compared to the initial proposal: