Skip to content

[Epic]: Central Package Management Improvements for 17.3 #11752

Closed

Description

@jeffkl

These items need to be addressed to make central package management production ready.

Issues

Features

Performance

Take performance measurements for large repositories to ensure that there is no regression in restore times. Also look for any optimizations that can be made.

  • Measure performance on a large repository

Visual Studio support

In parallel, we're working with the Project System team to support updating Directory.Packages.props instead of individual projects so the experience in the UI is correct.

Pull Requests

Activity

  1. self-assigned this
    on Apr 15, 2022
  2. added
    Type:TrackingThis issue is tracking the completion of other related issues.
    on Apr 15, 2022
  3. AArnott commented on May 9, 2022

    @AArnott
    Contributor

    Please seriously consider #9464 as part of this initial stable release. At the very least, before deferring it make sure that implementing it later won't require any breaking change that would block its delivery later. It's a very important scenario for us.

  4. jeffkl commented on May 9, 2022

    @jeffkl
    ContributorAuthor

    @AArnott I'm pretty sure #10389 covers this scenario. When you opt into it, any <PackageVersion /> defined will override a transitive dependency version without need to specify a top-level <PackageReference />. Do I understand #9464 correctly? Does that sound right to you?

  5. AArnott commented on May 12, 2022

    @AArnott
    Contributor

    No, that's not the same. #10389 is pinning of transitive dependencies, whereas #9464 is about not specifying package versions at all when it can be inferred via the transitive dependencies of another package whose version is specified.

  6. Nirmal4G commented on Jun 21, 2022

    @Nirmal4G

    @jeffkl I also propose the central package management be activated when the Directory.Packages.props or _DirectoryPackagesPropsFile is found and can be imported. Enabling via property manually is just another redundant churn. We can op-out by setting the property but opt-in should be default by the recognition of the presence of packages file.

  7. jeffkl commented on Jun 21, 2022

    @jeffkl
    ContributorAuthor

    @Nirmal4G I agree, that's something I'm planning on doing for the next release (Visual Studio 2022 17.4)

  8. changed the title [-][Epic]: Additional central package management features for the next release[/-] [+][Epic]: Central Package Management Improvements for 17.3[/+] on Jul 7, 2022
  9. edumserrano commented on Jul 14, 2022

    @edumserrano

    This might be the wrong place to add this info but docker support on Visual Studio 17.3 Preview 3 is broken when using Central Package Management.

    When I try to run in Visual Studio the dockerfile I keep getting a prompt to install a package which is already installed. Even if I reply yes to the prompt, I just get an error message on visual studio that just says Error without further information.
    image

    If I disable CPM, everything works as expected again.

  10. jeffkl commented on Jul 14, 2022

    @jeffkl
    ContributorAuthor

    @edumserrano please file a new issue for tracking and include exact steps I can follow to reproduce the problem which will greatly help with the investigation. Thanks for reporting this.

  11. edumserrano commented on Jul 15, 2022

    @edumserrano

    @jeffkl I've create this issue and a repo with further information to help debug this bug #11972.

    Hopefully it's a simple one.

  12. andrew-hampton commented on Jul 25, 2022

    @andrew-hampton

    @jeffkl is there an issue or something tracking the VS UI improvements so that I can follow the status of that work as well? Thanks

  13. jeffkl commented on Jul 29, 2022

    @jeffkl
    ContributorAuthor

    @andrew-hampton yes, it is here: #9015

  14. JonDouglas commented on Aug 26, 2022

    @JonDouglas
    Contributor

    @jeffkl Can we close as completed?

  15. jeffkl commented on Aug 29, 2022

    @jeffkl
    ContributorAuthor

    @jeffkl Can we close as completed?

    Yes good idea!

  16. menees commented on Aug 30, 2022

    @menees

    @jeffkl and @JonDouglas, why was this epic closed? I'm running VS 17.3.2, and I still get NuGet preview messages in VS and MSBuild on restores: The project ... is using CentralPackageVersionManagement, a NuGet preview feature.

    Issue #11724 was closed by @nkolev92 on Apr 18, but it doesn't appear that the preview message was ever taken out. It's certainly still present in VS 17.3.2 and MSBuild 17.3.1+2badb37d1. So, this epic shouldn't be closed, or its title and milestones should be updated, or #11724 should be reopened, or something.

    To a non-Microsoftie, it's extremely difficult to understand why it seems so difficult to get this CPM preview message turned off in VS. :-(

  17. JonDouglas commented on Aug 30, 2022

    @JonDouglas
    Contributor

    @menees See #11952

    This epic is complete as it is already out. We will continue to iterate with the next one.

  18. jeffkl commented on Aug 30, 2022

    @jeffkl
    ContributorAuthor

    @menees some of the features were pushed to the next release, including the removal of the preview message. As Jon mentioned, the next iteration of work is being tracked in #11952

    To a non-Microsoftie, it's extremely difficult to understand why it seems so difficult to get this CPM preview message turned off in VS. :-(

    I'm sorry for your frustration, I agree that the message should have had a setting to suppress it. I'll be sure to incorporate this feedback with future messages since they can't be suppressed out-of-the-box like warnings can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Area:RestoreCPMCentral package managementEpicPriority:2Issues for the current backlog.Type:TrackingThis issue is tracking the completion of other related issues.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions