Skip to content

Migration: uBlock Origin 1.76.0 #656

Closed

Description

@github-actions

@Nawid3333 CI failed twice on #654 (Toolchain update: uBlock Origin 1.76.0): the new version most likely needs changes to the code here, which no rerun or rebase brings. #654 is labelled hold meanwhile.

What failed

Job Failed step What the step checks
Lint, test and build Unit tests the unit tests (Vitest)
Unit tests (Windows) Unit tests the unit tests (Vitest)
The last lines of Lint, test and build

^[[36m ^[[2m❯^[[22m tests/unit/checkToolchain.test.mjs:^[[2m398:36^[[22m^[[39m
    ^[[90m396|^[[39m     const changed = (a, b) => a.split('\n').filter((line, i) => line !…
    ^[[90m397|^[[39m     expect(written.split('\n')).toHaveLength(text.split('\n').length);
    ^[[90m398|^[[39m     expect(changed(written, text)).toEqual([
    ^[[90m   |^[[39m                                    ^[[31m^^[[39m
    ^[[90m399|^[[39m       '    version: \'1.76.0\',',
    ^[[90m400|^[[39m       `    url: '${next.url}',`,


^[[31m^[[2m⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯^[[22m^[[39m

^[[2m Test Files ^[[22m ^[[1m^[[31m1 failed^[[39m^[[22m^[[2m | ^[[22m^[[1m^[[32m222 passed^[[39m^[[22m^[[2m | ^[[22m^[[33m1 skipped^[[39m^[[90m (224)^[[39m
^[[2m      Tests ^[[22m ^[[1m^[[31m1 failed^[[39m^[[22m^[[2m | ^[[22m^[[1m^[[32m3452 passed^[[39m^[[22m^[[2m | ^[[22m^[[33m37 skipped^[[39m^[[90m (3490)^[[39m
^[[2m   Start at ^[[22m 15:23:20
^[[2m   Duration ^[[22m 21.62s^[[2m (tests 73%, import 17%, transform 8%, worker 2%)^[[22m

^[[2m    Isolate ^[[22m ^[[33m224 workers spawned^[[39m^[[2m · ~87ms startup each (spawn + environment, per file)^[[22m
^[[2m            ^[[22m ^[[2mat least ~6.41s faster with ^[[22m^[[33misolate: false^[[39m^[[2m — reuses workers across files instead of one per file^[[22m

[ELIFECYCLE] Test failed. See above for more details.
##[error]Process completed with exit code 1.
Post job cleanup.
Pruning is unnecessary.
Post job cleanup.
[command]/usr/bin/git version
git version 2.56.0
Temporarily overriding HOME='/home/runner/work/_temp/139debbd-437e-43ad-8805-095086282983' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]/usr/bin/git config --global --add safe.directory /home/runner/work/FastStream/FastStream
Removing SSH command configuration
[command]/usr/bin/git config --local --name-only --get-regexp core\.sshCommand
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
Removing HTTP extra header
[command]/usr/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
Removing includeIf entries pointing to credentials config files
[command]/usr/bin/git config --local --name-only --get-regexp ^includeIf\.gitdir:
[command]/usr/bin/git submodule foreach --recursive git config --local --show-origin --name-only --get-regexp remote.origin.url
Cleaning up orphan processes
The last lines of Unit tests (Windows)
     ^[[33m^[[2m✓^[[22m^[[39m Test-ChangedSince: a lockfile newer than the install marker, or no marker^[[33m 989^[[2mms^[[22m^[[39m
     ^[[32m✓^[[39m install-node-elevated.ps1 ^[[2m(3)^[[22m
       ^[[33m^[[2m✓^[[22m^[[39m refuses its copy on the SHA-256, then on the OpenJS signature^[[33m 1661^[[2mms^[[22m^[[39m
       ^[[33m^[[2m✓^[[22m^[[39m New-AdminOnlyDirectory admits only Administrators and SYSTEM, and is owned by Administrators^[[33m 1006^[[2mms^[[22m^[[39m

^[[31m⎯⎯⎯⎯⎯⎯⎯^[[39m^[[1m^[[41m Failed Tests 1 ^[[49m^[[22m^[[31m⎯⎯⎯⎯⎯⎯⎯^[[39m

^[[41m^[[1m FAIL ^[[22m^[[49m tests/unit/checkToolchain.test.mjs^[[2m > ^[[22muBlock Origin in tools/setup-dev-profile.mjs^[[2m > ^[[22mreplaces its version, url and sha256, and nothing else
^[[31m^[[1mAssertionError^[[22m: expected [ …(2) ] to deeply equal [ '    version: \'1.76.0\',', …(2) ]^[[39m

^[[32m- Expected^[[39m
^[[31m+ Received^[[39m

^[[2m  [^[[22m
^[[32m-   "    version: '1.76.0',",^[[39m
^[[2m    "    url: 'https://addons.mozilla.org/firefox/downloads/file/5100000/ublock_origin-1.76.0.xpi',",^[[22m
^[[2m    "    sha256: 'bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb',",^[[22m
^[[2m  ]^[[22m

^[[36m ^[[2m❯^[[22m tests/unit/checkToolchain.test.mjs:^[[2m398:36^[[22m^[[39m
    ^[[90m396|^[[39m     const changed = (a, b) => a.split('\n').filter((line, i) => line !…
    ^[[90m397|^[[39m     expect(written.split('\n')).toHaveLength(text.split('\n').length);
    ^[[90m398|^[[39m     expect(changed(written, text)).toEqual([
    ^[[90m   |^[[39m                                    ^[[31m^^[[39m
    ^[[90m399|^[[39m       '    version: \'1.76.0\',',
    ^[[90m400|^[[39m       `    url: '${next.url}',`,

^[[31m^[[2m⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯^[[22m^[[39m


^[[2m Test Files ^[[22m ^[[1m^[[31m1 failed^[[39m^[[22m^[[2m | ^[[22m^[[1m^[[32m222 passed^[[39m^[[22m^[[2m | ^[[22m^[[33m1 skipped^[[39m^[[90m (224)^[[39m
^[[2m      Tests ^[[22m ^[[1m^[[31m1 failed^[[39m^[[22m^[[2m | ^[[22m^[[1m^[[32m3485 passed^[[39m^[[22m^[[2m | ^[[22m^[[33m4 skipped^[[39m^[[90m (3490)^[[39m
^[[2m   Start at ^[[22m 16:15:31
^[[2m   Duration ^[[22m 238.35s^[[2m (tests 95%, import 3%, transform 1%)^[[22m

^[[2m    Isolate ^[[22m ^[[33m224 workers spawned^[[39m^[[2m · ~144ms startup each (spawn + environment, per file)^[[22m
^[[2m            ^[[22m ^[[2mat least ~10.58s faster with ^[[22m^[[33misolate: false^[[39m^[[2m — reuses workers across files instead of one per file^[[22m

[ELIFECYCLE] Test failed. See above for more details.
##[error]Process completed with exit code 1.

What to do

  1. On a branch of its own off main, migrate/ublock-origin-1.76.0, an agent session or you change the code for uBlock Origin 1.76.0, with a test that pins the new behaviour, and open a pull request for it. If main fails as well (above), fix that first.
  2. Once that is merged: if it took the new version itself, toolchain-updates.yml closes Toolchain update: uBlock Origin 1.76.0 #654; otherwise Update branch on Toolchain update: uBlock Origin 1.76.0 #654 runs its CI again.
  3. CI passing on Toolchain update: uBlock Origin 1.76.0 #654 closes this issue and takes off the hold label it set; Toolchain update: uBlock Origin 1.76.0 #654 is then reported on as every update is.

Meanwhile, closing #654 skips this version for good; the next one comes as a pull request of its own.

This issue closes itself once CI passes on #654, or once #654 is merged or closed (checked daily).

Activity

  1. github-actions commented on Nov 9, 2026

    @github-actions
    Author
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions