Unmanaged Flag - #32
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Why did we decide not to memory manage TypeInterface and TypeId? It seems that now e.g. dispatch_queue_t CFReadStreamCopyDispatchQueue(CFReadStreamRef stream) isn't memory managed but ARC is able to do so.
Contributor
Author
There was a problem hiding this comment.
We didn't find a possible scenario where we should explicitly memory manage something that is TypeInterface or TypeId.
I experimented and created a method that returns a dispatch_queue_t and it seems that it is returned autoreleased so should we memory manage it ?
Contributor
There was a problem hiding this comment.
I think that we should, if we can.
Contributor
|
Updating the TypeScript declarations generator would ease the transition to the new API. |
Contributor
|
👍 from me |
KristinaKoeva
force-pushed
the
KristinaKoeva/AddUnmanagedFlag
branch
from
November 3, 2015 14:37
9db30bc to
0326e74
Compare
… an item, we could return a special Unmanaged type
KristinaKoeva
force-pushed
the
KristinaKoeva/AddUnmanagedFlag
branch
from
November 3, 2015 14:38
0326e74 to
cac579a
Compare
jasssonpet
added a commit
that referenced
this pull request
Nov 4, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an unmanaged flag so that when we don't know how to memory manage an item, we could return a special Unmanaged type