Refactor version switcher styles - #227
Merged
Merged
Conversation
Member
|
Hey - Thanks for your contribution. I've requested a review from our amazing frontend designer, Hassan, as well as the Contributor team. Appreciate your efforts :) |
gwleuverink
reviewed
Nov 6, 2025
gwleuverink
left a comment
gwleuverink
left a comment
Contributor
There was a problem hiding this comment.
Just a double check we can remove the focus styling. Other additions are 👍🏻
| class=" | ||
| inline-flex items-center | ||
| opacity-60 hover:opacity-100 transition-opacity duration-200 | ||
| focus-within:outline-2 focus-within:rounded-xs focus-within:outline-offset-2 |
Contributor
There was a problem hiding this comment.
Can we remove this focus state without providing an alternative? This is used when using keyboard navigation on the site. e.g. tab & space
Contributor
Author
There was a problem hiding this comment.
Great catch! Unfortunately, I haven't found an alternative method for that issue. The previous code is better for handling keyboard navigation and provides a better user experience, so let's stick with that one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When i explore your documentation, I found UI related issue on "Version Switcher" component in dark mode and there is border which affects user experience. look this before and after images:
Before :
After :