Repository navigation
Conversation
No changeset foundThis PR does not add a changeset, so it will not appear in the changelog or trigger a release. If the change is user-facing, add one: pnpm changesetPick a bump (patch / minor / major) and write the changelog entry in our usual voice ("Added X... Thanks to @you. Closes #123."), then commit the generated If this PR is docs-only or a chore that needs no release note, you can ignore this — or run |
nc-review: comments — 1 nit@DenizOkcu — a few things worth a look, none blocking. This PR tightens the knip configuration by dropping four ⚪ nit · After this PR,
🔴 blocking · 🟠 a reviewer would ask for a change · ⚪ optional Automated code review — correctness, security, design, tests, plus duplicates and scope. A human still decides; this is not a substitute for review and is not exhaustive. The required status checks separately cover lint, formatting, types, unused dependencies, the test suite and the build. This bot never merges. Maintainers can rerun with |
|
Hi @DenizOkcu, thanks for this PR! It looks like a maintainer has left feedback Whenever you get a chance, could you take a look at the open comments? |
Why
Split from #1570 following @addyCooks’ request for smaller PRs. This isolates unrelated scope (d) and is independent of the Ink upgrade.
Changes
.github/**exclusion.@internalannotations from exports used by configuration or tests.Validation
Whitespace checks pass. No runtime behavior changes intended; branch CI should run knip and typechecking.