Repository navigation
fix(tui): keep shortcuts overlay on screen and make it scrollable - #1865
Open
puri-adityakumar wants to merge 1 commit into
Open
puri-adityakumar wants to merge 1 commit into
puri-adityakumar wants to merge 1 commit into
Conversation
puri-adityakumar
marked this pull request as ready for review
October 20, 2026 16:01
puri-adityakumar
requested review from
addyCooks,
akramcodez and
will-lamerton
as code owners
October 20, 2026 16:01
Contributor
Author
|
Hey @akramcodez, could you please take a look at this when you have a moment? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #1813.
On short terminals, the
?shortcuts overlay ran off the bottom of the screen, cutting off the lower entries, the close hint, and the bottom border.SHORTCUTS_OVERHEAD_ROWS = 11inuser-input.tsx, leaving one spare row so Ink doesn't clear and redraw the full inline chat on every keypress) and scroll with Up/Down or PgUp/PgDn.wrap="truncate-end") so narrow terminals don't wrap rows and overflow the height budget.UserInputviaonShortcutsOverlayChange(including on unmount) soChatInputandInteractiveApphide the live task list and other footer rows while the overlay is open.scrollActive) while the overlay is open so PgUp/PgDn only move the overlay.60x18)60x18)Type of Change
Changeset
Testing
user-input.spec.tsx(18-row fit, 60-col single-line truncation, arrow/page scrolling, resize clamping, tall terminal, and open/close callback on unmount) andinteractive-app.spec.tsx(task list hidden at 18 rows, PgUp/PgDn don't scroll chat).user-input,user-input-completion,chat-input,chat-history, andinteractive-appspecs pass (186 tests), and all CI checks pass.60x18terminal with a 40-line chat and 3 live tasks.Checklist