Repository navigation
fix(providers): prefer current MiniMax text models - #1861
octo-patch wants to merge 2 commits into
Conversation
nc-review: comments — 1 important, 3 nits@octo-patch — a few things worth a look, none blocking. The PR changes the MiniMax wizard template default from 🟠 important · The policy is hide everything matching a MiniMax text prefix that is not in the hardcoded const output = filterMiniMaxModels(input, `https://${host}/anthropic/v1`);
// ... 'MiniMax-M3.1-Flash-Preview' is absent from the expected outputMiniMax gates new model rollouts behind ⚪ nit · The } else if (url.hostname === 'opencode.ai') {so every ⚪ nit ·
⚪ nit · Scope is justified and there is no drive-by churn: the runtime request path is untouched (the serializer already omits unsupported thinking/effort overrides, as the author notes), the only production edits are the template default, the new filter, and the two call sites. Flagging only that roughly half the diff is the new 🔴 blocking · 🟠 a reviewer would ask for a change · ⚪ optional Automated code review — correctness, security, design, tests, plus duplicates and scope. A human still decides; this is not a substitute for review and is not exhaustive. The required status checks separately cover lint, formatting, types, unused dependencies, the test suite and the build. This bot never merges. Maintainers can rerun with |
Reason: New MiniMax configurations still suggest M3/M2.7, and model discovery can surface retired MiniMax text IDs. Default new configurations to M3.1 Flash with M3 as the alternative, and narrow discovery to current verified text routes.
Description
Update the MiniMax setup template and configuration example. Apply the same discovery policy in the setup wizard and model browser: use the exact official endpoint hosts and verified gateway IDs, retain only models actually returned by discovery, and prefer Flash over M3. Saved configurations and manually entered IDs remain valid; custom endpoints, media entries, and unrelated model choices retain their existing behavior.
The existing direct API serializer already omits unsupported thinking/effort overrides, so this change does not add a runtime adapter or alter request settings. Documentation distinguishes the international M Plan's documented Flash support from account-specific access to M3.
References: MiniMax Anthropic API, M Plan configuration.
Type of Change
Changeset
Testing
Automated Tests
source/acp/acp-agent.ts; the same diagnostic reproduces on the unchanged base.inkhas noTextexport) and three terminal-width/file-timestamp assertions. The regular CLI integration tests pass after building. The stable full-suite rerun ends with those same 37 failures, 15 skipped tests, and 112 pending after timeouts in the metadata and plain-conversation suites. All 112 tests pass when those two suites are rerun alone; their unchanged-base counterparts also pass alone.Manual Testing
No live inference was performed. Subscription entitlement and live gateway inference availability were not tested. A public gateway catalog refresh returned HTTP 403; the discovery filter only retains verified IDs when the configured gateway actually returns them.
Checklist