fix(exec): query the frame allocator from the receiver's environment - #2249
Merged
Conversation
exec::function chose its frame allocator by calling __choose_frame_allocator with the *receiver* itself instead of the receiver's environment. Allocation always fell back to std::allocator.
ericniebler
approved these changes
Sep 3, 2026
ericniebler
left a comment
ericniebler
left a comment
Collaborator
There was a problem hiding this comment.
nice catch! a couple of minor tweaks and this one is good.
Co-authored-by: Eric Niebler <eniebler@boost.org>
Collaborator
|
/ok to test cd5a8ba |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
exec::function chose its frame allocator by calling __choose_frame_allocator with the receiver itself instead of the receiver's environment. Allocation always fell back to std::allocator.