Repository navigation
Conversation
skills/ in ai-dynamo/dynamo is a symlink to .agents/skills/, which git sparse-checkout does not resolve, so the sync workflow found nothing at any skills/dynamo-*/ path. dynamo-recipe-runner and dynamo-troubleshoot were also renamed upstream to deploy-dynamo-recipe and troubleshoot-dynamo respectively. Update the path fields in components.d/dynamo.yml to the current .agents/skills/ locations and names; catalog_dir is left unchanged to preserve existing skills/ catalog URLs. Signed-off-by: Sammy Tourani <sammytourani@gmail.com>
mosheabr
requested review from
jasonnvidia,
sayalinvidia and
siqinvidia
as code owners
September 25, 2026 02:10
This was referenced Sep 25, 2026
This was referenced Oct 2, 2026
jasonnvidia
requested changes
Oct 6, 2026
jasonnvidia
left a comment
jasonnvidia
left a comment
Collaborator
There was a problem hiding this comment.
signing authors fails on this one and the sig doesn't match...
should we just recreate this change in a new PR it's basically just moving skills to .agents/skills folder for dyanmo skills... but I think someone needs to tell dynamo team to rerun the Skill sig because their skills are newer than their sigs.
This was referenced Oct 22, 2026
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #563. Replacement for #609 — same commit (cf4de9b), moved to a same-repo branch because fork-PR CI is currently unsupported (fork-based signing/CI was reverted 2026-08-06, #422); the original PR's head commit never received a single CI status.
Onboarding type
components.d/<slug>.ymlfile)Other context
Original author: @SammyTourani (external contributor). Verified independently before recreating this branch:
skills/inai-dynamo/dynamois confirmed (via GitHub API) to be a symlink to.agents/skills/—git sparse-checkoutdoes not resolve symlinks, which is the root cause of the sync workflow's "empty or missing" failures for all 4 Dynamo skills..agents/skills/paths in this diff resolve correctly.catalog_dircorrectly left unchanged for all four entries, preserving existingskills/<dir>/catalog URLs — matches established policy thatcatalog_dirdoesn't need to track upstream renames.Known follow-up, not blocking this fix: 2 of the 4 target skills are incomplete at the source and will likely be held after syncing (same graceful-degradation path as other missing-signature cases already in the catalog), not a regression from this PR:
deploy-dynamo-recipe(renamed fromdynamo-recipe-runner) has onlySKILL.md— no evals, benchmark, or signature.troubleshoot-dynamo(renamed fromdynamo-troubleshoot) hasSKILL.md/evals/references/scriptsbut noBENCHMARK.md,skill-card.md, orskill.oms.sig.The other two (
dynamo-interconnect-check,dynamo-router-starter) have full artifacts, though theirBENCHMARK.mdshows Tier 3 never ran ("not available in this report").Flagging the incomplete-skill gap to the Dynamo team separately; this PR only fixes the sync path mechanism, which is a real and verified improvement over the current total-failure state.
All PRs