Skip to content

ibgda: Trap on error CQEs in release builds #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
unionxic wants to merge 1 commit into
base: devel
Choose a base branch
from
+8 −0
Open

ibgda: Trap on error CQEs in release builds #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/include/non_abi/device/pt-to-pt/ibgda_device.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1731,6 +1731,10 @@ ibgda_quiet(nvshmemi_ibgda_device_qp_t *qp) {
}
#endif
assert(likely(status == 0));
// CQE errors are fatal (see ibgda_poll_cq); release builds compile the assert out.
if (unlikely(status != 0)) {
__trap();
}
return prod_idx;
}

Expand All @@ -1749,6 +1753,10 @@ __device__ NVSHMEMI_STATIC NVSHMEMI_DEVICE_ALWAYS_INLINE void ibgda_wait_for_slo
printf("ibgda_poll_cq failed with error=%d.\n", err);
}
assert(likely(status == 0));
// CQE errors are fatal (see ibgda_poll_cq); release builds compile the assert out.
if (unlikely(status != 0)) {
__trap();
}
}
IBGDA_MFENCE();
}
Expand Down