Skip to content

Validate CUDA host warning flags independently #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cherubrock-seb wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −8
Open

Validate CUDA host warning flags independently #498

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions cmake/NVBenchConfigTarget.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
include(CheckCXXCompilerFlag)
include(CheckCompilerFlag)

option(NVBench_ENABLE_WERROR
"Treat warnings as errors while compiling NVBench."
Expand All @@ -22,20 +22,29 @@ set_target_properties(nvbench.build_interface PROPERTIES
)

function(nvbench_add_cxx_flag target_name type flag)
string(MAKE_C_IDENTIFIER "NVBench_CXX_FLAG_${flag}" var)
check_cxx_compiler_flag(${flag} ${var})
string(MAKE_C_IDENTIFIER "NVBench_CXX_FLAG_${flag}" cxx_var)
check_compiler_flag(CXX "${flag}" ${cxx_var})

if (${${var}})
if (${cxx_var})
target_compile_options(${target_name} ${type}
$<$<COMPILE_LANGUAGE:CXX>:${flag}>
$<$<COMPILE_LANG_AND_ID:CUDA,NVIDIA>:-Xcompiler=${flag}>
)
endif()

if (CMAKE_CUDA_COMPILER_ID STREQUAL "NVIDIA")
string(MAKE_C_IDENTIFIER "NVBench_CUDA_HOST_FLAG_${flag}" cuda_host_var)
check_compiler_flag(CUDA "-Xcompiler=${flag}" ${cuda_host_var})

if (${cuda_host_var})
target_compile_options(${target_name} ${type}
$<$<COMPILE_LANG_AND_ID:CUDA,NVIDIA>:-Xcompiler=${flag}>
)
endif()
endif()
endfunction()

# We test to see if C++ compiler options exist using try-compiles in the CXX lang, and then reuse those flags as
# -Xcompiler flags for CUDA targets. This requires that the CXX compiler and CUDA_HOST compilers are the same when
# using nvcc.
# Check warning support independently for the C++ compiler and the CUDA host compiler. The top-level developer
# build check below still requires matching compilers when using nvcc.
if (NVBench_TOPLEVEL_PROJECT AND CMAKE_CUDA_COMPILER_ID STREQUAL "NVIDIA")
set(cuda_host_matches_cxx_compiler FALSE)
if (CMAKE_VERSION VERSION_GREATER_EQUAL 3.31)
Expand Down
Loading