Repository navigation
Fix for NN Descent negative or NaN distances - #994
Merged
Merged
Conversation
jinsolp
added
bug
divyegala
reviewed
Jun 9, 2025
divyegala
left a comment
divyegala
left a comment
Contributor
There was a problem hiding this comment.
Should we add this guard for L2Expanded as well? Considering we may return negative distances
Contributor
Author
|
This PR handles both L2Expanded and L2SqrtExpanded. |
divyegala
approved these changes
Jun 9, 2025
Contributor
Author
|
@divyegala Think this is ready to go! |
Contributor
|
/merge |
bkarsin
pushed a commit
to bkarsin/cuvs
that referenced
this pull request
Jun 19, 2025
Closes NVIDIA#991 Authors: - Jinsol Park (https://github.com/jinsolp) Approvers: - Tarang Jain (https://github.com/tarang-jain) - Divye Gala (https://github.com/divyegala) URL: NVIDIA#994
landrumb
pushed a commit
to landrumb/cuvs
that referenced
this pull request
Jul 8, 2026
Closes NVIDIA#991 Authors: - Jinsol Park (https://github.com/jinsolp) Approvers: - Tarang Jain (https://github.com/tarang-jain) - Divye Gala (https://github.com/divyegala) URL: NVIDIA#994
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #991