Skip to content

Add test parameter space guidance to cpp REVIEW_GUIDELINES - #2711

Merged
rapids-bot[bot] merged 4 commits into
NVIDIA:mainfrom
robertmaynard:teach_code_rabbit_to_review_based_on_test_cost
Oct 3, 2026
Merged

rapids-bot[bot] merged 4 commits into
NVIDIA:mainfrom
robertmaynard:teach_code_rabbit_to_review_based_on_test_cost

Conversation

@robertmaynard

Copy link
Copy Markdown
Contributor

Capture the lessons from the CI turn-around work in #2573, #2579, and without increasing coverage.

Capture the lessons from the CI turn-around work in NVIDIA#2573, NVIDIA#2579, and
without increasing coverage.
@robertmaynard
robertmaynard requested a review from a team as a code owner October 1, 2026 14:59
@robertmaynard robertmaynard added doc Improvements or additions to documentation feature request New feature or request labels Oct 1, 2026
@robertmaynard robertmaynard added non-breaking Introduces a non-breaking change and removed feature request New feature or request labels Oct 1, 2026

@msarahan msarahan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! I wonder if some equivalent or derivative of this in AGENTS.md would help agents write tests more efficiently to begin with, rather than catching them once a PR is up.

@robertmaynard

Copy link
Copy Markdown
Contributor Author

Excellent! I wonder if some equivalent or derivative of this in AGENTS.md would help agents write tests more efficiently to begin with, rather than catching them once a PR is up.

Currently cuVS doesn't have an AGENTS.md. or a .agents/skills/ directory. Once the teams determines how it wants to handle agent skills, I agree we can add this.

@cjnolet

cjnolet commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

/merge

@rapids-bot
rapids-bot Bot merged commit c68b667 into NVIDIA:main Oct 3, 2026
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Improvements or additions to documentation non-breaking Introduces a non-breaking change

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants