Skip to content

Fix multi-threading in single-rank sharded batch search #2704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 3 commits into from
Sep 30, 2026
Merged

Fix multi-threading in single-rank sharded batch search #2704

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f34d3f1
Fix race in single-rank sharded batch search
tarang-jain Sep 29, 2026
4fb5310
Simplify comment for single rank processing
tarang-jain Sep 30, 2026
9daa863
Merge branch 'main' into fix/annmg-single-rank-batching
tarang-jain Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/src/neighbors/mg/snmg.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -754,8 +754,8 @@ void search(const raft::resources& clique,
n_neighbors,
n_batches);
} else {
// Only one rank is available, so process its batches sequentially.
const int rank = 0;
#pragma omp parallel for
for (int64_t batch_idx = 0; batch_idx < n_batches; batch_idx++) {
int64_t offset = batch_idx * n_rows_per_batch;
int64_t query_offset = offset * n_cols;
Expand Down
Loading