Repository navigation
Remove unimplemented cagra search apis - #2600
Merged
Merged
Conversation
aamijar
added
non-breaking
aamijar
changed the title
tarang-jain
requested changes
Sep 14, 2026
| raft::device_matrix_view<float, int64_t, raft::row_major> distances, | ||
| const cuvs::neighbors::filtering::base_filter& sample_filter = | ||
| cuvs::neighbors::filtering::none_sample_filter{}); | ||
| void search(raft::resources const& res, |
Contributor
There was a problem hiding this comment.
we can leave the device_standard_index APIs as is. We can create the padded view ourselves if needed. If the dim is not aligned, only then we can error out.
Member
Author
There was a problem hiding this comment.
Alright I'll change it so that we call the search kernel if its already aligned, instead of always erroring out.
tarang-jain
approved these changes
Sep 29, 2026
Member
Author
|
/merge |
maxwbuckley
added a commit
to maxwbuckley/cuvs
that referenced
this pull request
Oct 6, 2026
Upstream moved cagra::search_params earlier in cagra.hpp (NVIDIA#2600). Resolved by keeping main's layout and dropping the duplicate filtering_rate field from it, since it is now inherited from cuvs::neighbors::search_params; upstream's UDF fallback documentation is carried into the replacement comment. The base-struct doc now says the popcount + sync applies to bitset_filter, since CAGRA's bloom and roaring filters derive the rate without one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cagra search APIs with vpq f32 are not implemented and result in a runtime error. Same goes for cagra search and MG cagra search on standard datasets.
Instead users should get a compile/link time error. We should simply remove the apis and the vpq_f32_index type which doesn't have any use cases currently.
Update: We will keep the cagra search and MG cagra search on standard dataset, and simply implement the path where if the alignment meets cagra's requirements we can call the search function. However, if it doesn't we can give an error.