Skip to content

Allow overriding build type via env var - #2429

Open
achirkin wants to merge 8 commits into
NVIDIA:mainfrom
achirkin:fea-libcuvs-build-type
Open

achirkin wants to merge 8 commits into
NVIDIA:mainfrom
achirkin:fea-libcuvs-build-type

Conversation

@achirkin

Copy link
Copy Markdown
Contributor

Allow overriding the CMAKE_BUILD_TYPE in the build.sh script via environment variables.

Mirrors the LIBCUVS_BUILD_DIR pattern.

This allows, for example, writing LIBCUVS_BUILD_TYPE=RelWithDebInfo ./build.sh to build cuvs with debug symbols and optimization enabled - without modifying the build script.

@achirkin achirkin self-assigned this Aug 11, 2026
@achirkin achirkin added the feature request New feature or request label Aug 11, 2026
@achirkin
achirkin requested a review from a team as a code owner August 11, 2026 07:07
@achirkin
achirkin requested a review from bdice August 11, 2026 07:07
@achirkin achirkin added non-breaking Introduces a non-breaking change Enhancement labels Aug 11, 2026
@achirkin achirkin moved this to In Progress in Unstructured Data Processing Aug 11, 2026
@coderabbitai

coderabbitai Bot commented Oct 8, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/cuvs/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 4fe217ff-ac2d-4b96-bb09-641a5d079153
📥 Commits

Reviewing files that changed from the base of the PR and between 28a9ec1 and c7c5829.

📒 Files selected for processing (1)
  • build.sh

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Chores
    • Build configuration now supports setting the build type through LIBCUVS_BUILD_TYPE, defaulting to Release when unset.

Walkthrough

The build script now uses LIBCUVS_BUILD_TYPE as the build-type default when set, and otherwise uses Release. The CMake configure command quotes the build-type value.

Changes

Build configuration

Layer / File(s) Summary
Build type selection and configuration
build.sh
BUILD_TYPE now defaults to LIBCUVS_BUILD_TYPE or Release. The CMake configure command quotes the expanded build-type value.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to c7c58

The build-type environment override is a bounded configuration change, and no material merge risk is established.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: allowing the build type to be overridden through an environment variable.
Description check ✅ Passed The description directly explains the build type override, the environment variable name, the existing pattern it follows, and an example use case.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement feature request New feature or request non-breaking Introduces a non-breaking change

Projects

Status: Approved

Development

Successfully merging this pull request may close these issues.

2 participants