Repository navigation
Adding more tests and I find the compression settings are broken in the Golang API - #1472
Merged
Merged
Conversation
cjnolet
added
bug
Contributor
|
/ok to test 2453b85 |
benfred
approved these changes
Oct 28, 2025
benfred
left a comment
benfred
left a comment
Contributor
There was a problem hiding this comment.
changes look good to me! Thanks for fixing the compression params and adding the tests
Contributor
|
/merge |
github-project-automation
Bot
moved this from In Progress
to Done
in Unstructured Data Processing
landrumb
pushed a commit
to landrumb/cuvs
that referenced
this pull request
Jul 8, 2026
…he Golang API (NVIDIA#1472) CreateCompressionParams in index_params.go currently does not work. It always throws an error ""memory allocation failed". This PR fixes that issue and adds a bunch more tests, both to some of the specific files and to cagra_test.go. I noted that enabling the compression params in cagra_test.go makes the test values not deterministic even if I set the seed. Is this intentional? I looked around online and did not spot a way to set the seed in cuVS. At first I thought it was some C++ variable being not initalized, but added tests verifying all the settings in the compression params... Thanks Authors: - Max Buckley (https://github.com/maxwbuckley) Approvers: - Ben Frederickson (https://github.com/benfred) URL: NVIDIA#1472
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CreateCompressionParams in index_params.go currently does not work. It always throws an error ""memory allocation failed". This PR fixes that issue and adds a bunch more tests, both to some of the specific files and to cagra_test.go.
I noted that enabling the compression params in cagra_test.go makes the test values not deterministic even if I set the seed. Is this intentional? I looked around online and did not spot a way to set the seed in cuVS. At first I thought it was some C++ variable being not initalized, but added tests verifying all the settings in the compression params...
Thanks