Skip to content

Audit cagra.hpp template functions #2691

Open
Open
Audit cagra.hpp template functions#2691
Labels
improvementImproves an existing functionality

Description

@aamijar
aamijar
opened on Sep 24, 2026

There seems to be some functions in cagra.hpp that are template functions. That is contrary to our typical pattern of using concrete overloads.

Activity

  1. github-project-automation
    added this to Unstructured Data Processingon Sep 24, 2026
  2. github-project-automation
    moved this to Needs Triage in Unstructured Data Processingon Sep 24, 2026
  3. aamijar
    added
    improvementImproves an existing functionality
    on Sep 24, 2026
  4. aamijar
    changed the title [-]Audit cagra.hpp template functions[/-] [+]Audit `cagra.hpp` template functions[/+] on Sep 24, 2026
  5. aamijar
    removed this from Unstructured Data Processingon Sep 24, 2026
  6. aamijar
    moved this to Todo in Unstructured Data Processingon Sep 24, 2026
  7. aamijar
    added this to Unstructured Data Processingon Sep 24, 2026

  8. cjnolet commented on Sep 30, 2026

    @cjnolet
    cjnolet
    on Sep 30, 2026
    Contributor

    Template methods and templated classes are okay in hpp files (for e.g. cagra index class), but templated free functions are not okay. If this is the case, I agree they should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    improvementImproves an existing functionality

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions