Handling global phase in Quake to P0 conversion by sacpis · Pull Request #5860 · NVIDIA/cuda-quantum

sacpis · 2026-11-06T17:57:11Z

Since #5839 made optimization level 2 the default, the T-count optimizer can emit an uncontrolled quake.phase, causing Quake-to-P0 import to fail with

'quake.phase' op is outside the typed Quake-to-P0 conversion contract

Here we have handled global phases directly in the converter, emitting no P0 operation while forwarding wire ownership, measurement state, and reference provenance. Controlled phases remain explicitly rejected because they affect relative phase.

Signed-off-by: Sachin Pisal <spisal@nvidia.com>

github-actions · 2026-11-06T19:02:03Z

CI Summary (`push`) — ✅ passed

Run #42322800556 · ✅ 8 · ⏩ 11 · ❌ 0 · ⛔ 0

Top-level jobs (19)

Job	Result
`binaries`	⏩ skipped
`build_and_test`	✅ success
`changes`	✅ success
`config_devdeps`	✅ success
`config_source_build`	⏩ skipped
`config_wheeldeps`	✅ success
`devdeps`	✅ success
`docker_image`	⏩ skipped
`documentation`	✅ success
`edem_wheels`	⏩ skipped
`gen_code_coverage`	⏩ skipped
`metadata`	✅ success
`python_devel_wheel`	⏩ skipped
`python_metapackages`	⏩ skipped
`python_wheels`	⏩ skipped
`python_wheels_cu12_validation`	⏩ skipped
`python_wheels_cu13`	⏩ skipped
`source_build`	⏩ skipped
`wheeldeps`	✅ success

⏩ Skipped jobs (11) — intentionally skipped on PR builds; run on merge_group / workflow_dispatch

Job
`binaries`
`config_source_build`
`docker_image`
`edem_wheels`
`gen_code_coverage`
`python_devel_wheel`
`python_metapackages`
`python_wheels_cu12_validation`
`python_wheels_cu13`
`python_wheels`
`source_build`

All sub-jobs (48) — every matrix leg, with links

Job	Status	Link
Build and test (amd64, gcc12, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (amd64, gcc12, openmpi) / Dev environment (Python)	✅ success	view
Build and test (amd64, llvm, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (amd64, llvm, openmpi) / Dev environment (Python)	✅ success	view
Build and test (arm64, llvm, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (arm64, llvm, openmpi) / Dev environment (Python)	✅ success	view
CI Summary	❔ in_progress	view
Check for stable CUDA-Q changes	✅ success	view
Configure build (devdeps)	✅ success	view
Configure build (source_build)	⏩ skipped	view
Configure build (wheeldeps)	✅ success	view
Create CUDA 12 Python wheels	⏩ skipped	view
Create CUDA 13 Python wheels	⏩ skipped	view
Create CUDA Quantum installer	⏩ skipped	view
Create Docker images	⏩ skipped	view
Create Python metapackages	⏩ skipped	view
Create cudaq-edem wheels (${{ matrix.platform }})	⏩ skipped	view
Create shared Python development wheel	⏩ skipped	view
Documentation / Build and check docs	✅ success	view
Gen code coverage	⏩ skipped	view
Load dependencies (amd64, gcc12) / Caching	✅ success	view
Load dependencies (amd64, gcc12) / Finalize	✅ success	view
Load dependencies (amd64, gcc12) / Metadata	✅ success	view
Load dependencies (amd64, llvm) / Caching	✅ success	view
Load dependencies (amd64, llvm) / Finalize	✅ success	view
Load dependencies (amd64, llvm) / Metadata	✅ success	view
Load dependencies (arm64, gcc12) / Caching	✅ success	view
Load dependencies (arm64, gcc12) / Finalize	✅ success	view
Load dependencies (arm64, gcc12) / Metadata	✅ success	view
Load dependencies (arm64, llvm) / Caching	✅ success	view
Load dependencies (arm64, llvm) / Finalize	✅ success	view
Load dependencies (arm64, llvm) / Metadata	✅ success	view
Load source build cache	⏩ skipped	view
Load wheel dependencies (amd64, 12.6) / Caching	✅ success	view
Load wheel dependencies (amd64, 12.6) / Finalize	✅ success	view
Load wheel dependencies (amd64, 12.6) / Metadata	✅ success	view
Load wheel dependencies (amd64, 13.0) / Caching	✅ success	view
Load wheel dependencies (amd64, 13.0) / Finalize	✅ success	view
Load wheel dependencies (amd64, 13.0) / Metadata	✅ success	view
Load wheel dependencies (arm64, 12.6) / Caching	✅ success	view
Load wheel dependencies (arm64, 12.6) / Finalize	✅ success	view
Load wheel dependencies (arm64, 12.6) / Metadata	✅ success	view
Load wheel dependencies (arm64, 13.0) / Caching	✅ success	view
Load wheel dependencies (arm64, 13.0) / Finalize	✅ success	view
Load wheel dependencies (arm64, 13.0) / Metadata	✅ success	view
Prepare cache clean-up	❔ in_progress	view
Retrieve PR info	✅ success	view
Validate CUDA 12 Python wheels	⏩ skipped	view

✅ Required checks (7/7) — declared in .github/required-checks.yml for push

Required check	Status	Link
Build and test (amd64, llvm, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (amd64, llvm, openmpi) / Dev environment (Python)	✅ success	view
Build and test (arm64, llvm, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (arm64, llvm, openmpi) / Dev environment (Python)	✅ success	view
Build and test (amd64, gcc12, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (amd64, gcc12, openmpi) / Dev environment (Python)	✅ success	view
Documentation / Build and check docs	✅ success	view

Signed-off-by: Sachin Pisal <spisal@nvidia.com>

cabreraam

Mostly LGTM! Just have the one comment about hydrateReferenceWires.

Thanks @sacpis

atgeller

LGTM 👍

Signed-off-by: Sachin Pisal <spisal@nvidia.com>

github-actions · 2026-11-07T16:55:29Z

CI Summary (`merge_group`) — ✅ passed

Run #42389830765 · ✅ 5 · ⏩ 14 · ❌ 0 · ⛔ 0

⚡ Fast merge queue — only the llvm dev-environment build+test legs ran.
Wheels, metapackages, installers, Docker images, and the gcc12 legs were skipped.
Set the repository variable MERGE_QUEUE_FAST to false to restore the full matrix.

Top-level jobs (19)

Job	Result
`binaries`	⏩ skipped
`build_and_test`	✅ success
`changes`	✅ success
`config_devdeps`	✅ success
`config_source_build`	⏩ skipped
`config_wheeldeps`	⏩ skipped
`devdeps`	✅ success
`docker_image`	⏩ skipped
`documentation`	⏩ skipped
`edem_wheels`	⏩ skipped
`gen_code_coverage`	⏩ skipped
`metadata`	✅ success
`python_devel_wheel`	⏩ skipped
`python_metapackages`	⏩ skipped
`python_wheels`	⏩ skipped
`python_wheels_cu12_validation`	⏩ skipped
`python_wheels_cu13`	⏩ skipped
`source_build`	⏩ skipped
`wheeldeps`	⏩ skipped

⏩ Skipped jobs (14) — intentionally skipped on PR builds; run on merge_group / workflow_dispatch

Job
`binaries`
`config_source_build`
`config_wheeldeps`
`docker_image`
`documentation`
`edem_wheels`
`gen_code_coverage`
`python_devel_wheel`
`python_metapackages`
`python_wheels_cu12_validation`
`python_wheels_cu13`
`python_wheels`
`source_build`
`wheeldeps`

All sub-jobs (29) — every matrix leg, with links

Job	Status	Link
Build and test (amd64, llvm, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (amd64, llvm, openmpi) / Dev environment (Python)	✅ success	view
Build and test (arm64, llvm, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (arm64, llvm, openmpi) / Dev environment (Python)	✅ success	view
CI Summary	❔ in_progress	view
Check for stable CUDA-Q changes	✅ success	view
Configure build (devdeps)	✅ success	view
Configure build (source_build)	⏩ skipped	view
Configure build (wheeldeps)	⏩ skipped	view
Create CUDA 12 Python wheels	⏩ skipped	view
Create CUDA 13 Python wheels	⏩ skipped	view
Create CUDA Quantum installer	⏩ skipped	view
Create Docker images	⏩ skipped	view
Create Python metapackages	⏩ skipped	view
Create cudaq-edem wheels (${{ matrix.platform }})	⏩ skipped	view
Create shared Python development wheel	⏩ skipped	view
Documentation	⏩ skipped	view
Gen code coverage	⏩ skipped	view
Load dependencies (amd64, llvm) / Caching	✅ success	view
Load dependencies (amd64, llvm) / Finalize	✅ success	view
Load dependencies (amd64, llvm) / Metadata	✅ success	view
Load dependencies (arm64, llvm) / Caching	✅ success	view
Load dependencies (arm64, llvm) / Finalize	✅ success	view
Load dependencies (arm64, llvm) / Metadata	✅ success	view
Load source build cache	⏩ skipped	view
Load wheel dependencies	⏩ skipped	view
Prepare cache clean-up	❔ in_progress	view
Retrieve PR info	✅ success	view
Validate CUDA 12 Python wheels	⏩ skipped	view

✅ Required checks (4/4) — declared in .github/required-checks.yml for merge_group_fast

Required check	Status	Link
Build and test (amd64, llvm, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (amd64, llvm, openmpi) / Dev environment (Python)	✅ success	view
Build and test (arm64, llvm, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (arm64, llvm, openmpi) / Dev environment (Python)	✅ success	view

Since #5839 made optimization level 2 the default, the T-count optimizer can emit an uncontrolled quake.phase, causing Quake-to-P0 import to fail with ``` 'quake.phase' op is outside the typed Quake-to-P0 conversion contract ``` Here we have handled global phases directly in the converter, emitting no P0 operation while forwarding wire ownership, measurement state, and reference provenance. Controlled phases remain explicitly rejected because they affect relative phase. --------- Signed-off-by: Sachin Pisal <spisal@nvidia.com>

schweitzpgi · 2026-11-10T17:30:29Z

Shouldn't P0 have global phase? That seems like a pretty major omission, eh?

…VIDIA#5881) Closes NVIDIA#5880. Follow-up to the [review discussion](NVIDIA#5860 (comment)) on NVIDIA#5860. The Quake-to-QLX converter tracked several live wires per reference, but valid Quake never produces that. `convert-to-linear-values` unwraps each `!quake.ref` once and wraps it back once, and it merges duplicate `extract_ref`s of the same element. ### What we changed here - Removing the alias tracking (`hydrateReference*`, `refreshReferenceAliases`, `commitReferenceWireResults`, and the slot maps). In a helper, `unwrap` reads the reference's slot and `wrap` writes it back. - Adding `erase-quake-global-phase`, the first pass in `prepare-quake-for-qlx`. It erases uncontrolled `quake.phase`. The converter still rejects controlled phase. - Deleting checks that guard only the converter's own state, or rules the Quake verifier already enforces. --------- Signed-off-by: Sachin Pisal <spisal@nvidia.com>

dropping global quake.phase before Quake to P0 import

c64a5ca

Signed-off-by: Sachin Pisal <spisal@nvidia.com>

sacpis requested a review from taalexander November 6, 2026 17:57

github-actions Bot added the cuda-q logical Related to CUDA-Q Logical. label Nov 6, 2026

ignoring global phase during Quake to P0 conversion

ff6ccc8

Signed-off-by: Sachin Pisal <spisal@nvidia.com>

sacpis changed the title ~~Dropping global quake.phase before Quake to P0 import~~ Handling global phase in Quake to P0 conversion Nov 6, 2026

cabreraam self-requested a review November 6, 2026 19:09

cabreraam reviewed Nov 6, 2026

View reviewed changes

Comment thread preview/logical/ir/lib/Conversion/QuakeToQLX/QuakeToQLX.cpp Resolved

Comment thread preview/logical/ir/lib/Conversion/QuakeToQLX/QuakeToQLX.cpp Resolved

sacpis added 2 commits November 6, 2026 13:55

tidy quake.phase anchor check in Quake to P0 conversion

3203fb9

Signed-off-by: Sachin Pisal <spisal@nvidia.com>

Merge branch 'main' into fix_logical_quake_phase

8c8115a

sacpis requested a review from cabreraam November 6, 2026 21:56

cabreraam approved these changes Nov 6, 2026

View reviewed changes

Comment thread preview/logical/ir/lib/Conversion/QuakeToQLX/QuakeToQLX.cpp Resolved

Merge branch 'main' into fix_logical_quake_phase

853a385

atgeller approved these changes Nov 6, 2026

View reviewed changes

using a single unwrap in the reference helper phase test

0295ecd

Signed-off-by: Sachin Pisal <spisal@nvidia.com>

sacpis requested a review from schweitzpgi November 6, 2026 23:52

Merge branch 'main' into fix_logical_quake_phase

f9a3e28

sacpis added this pull request to the merge queue Nov 7, 2026

Merged via the queue into NVIDIA:main with commit 40c8e5e Nov 7, 2026
257 checks passed

sacpis deleted the fix_logical_quake_phase branch November 7, 2026 17:17

github-actions Bot pushed a commit that referenced this pull request Nov 7, 2026

Cleaning up docs preview for PR #5860.

95c84c1

sacpis mentioned this pull request Nov 10, 2026

Quake-to-QLX conversion tracks qubit aliasing that valid Quake never produces #5880

Closed

3 of 4 tasks

This was referenced Nov 10, 2026

[Follow up] Dropping reference aliasing from Quake-to-QLX conversion #5881

Merged

Check P0 linearity in C++, not only in Python #5883

Open

Build QuakeToQLX only when the CUDA-Q SDK is enabled #5884

Open

Add one pipeline for Quake-to-QLX conversion #5885

Open

sacpis mentioned this pull request Nov 11, 2026

Enforcing linear ownership of QLX values in C++ verifiers #5889

Open

bettinaheim added the no release notes Don't list this PR in the release notes label Nov 12, 2026

bettinaheim added this to the release 0.17.0 milestone Nov 12, 2026

Navigation Menu

Repository navigation

Handling global phase in Quake to P0 conversion - #5860

Handling global phase in Quake to P0 conversion#5860
sacpis merged 7 commits into
NVIDIA:mainfrom
sacpis:fix_logical_quake_phase

sacpis commented Nov 6, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Nov 6, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

cabreraam left a comment •

edited

Loading

Uh oh!

Uh oh!

atgeller left a comment

Uh oh!

github-actions Bot commented Nov 7, 2026

Uh oh!

Uh oh!

schweitzpgi commented Nov 10, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

sacpis commented Nov 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Nov 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Summary (push) — ✅ passed

Uh oh!

Uh oh!

Uh oh!

cabreraam left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

atgeller left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Nov 7, 2026

CI Summary (merge_group) — ✅ passed

Uh oh!

Uh oh!

schweitzpgi commented Nov 10, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sacpis commented Nov 6, 2026 •

edited

Loading

github-actions Bot commented Nov 6, 2026 •

edited

Loading

CI Summary (`push`) — ✅ passed

cabreraam left a comment •

edited

Loading

CI Summary (`merge_group`) — ✅ passed