Repository navigation
Add host-bulk for_each for static_map - #565
Merged
Merged
Conversation
srinivasyadav18
requested review from
PointKernel and
sleeepyjack
as code owners
July 29, 2024 17:20
Collaborator
|
/ok to test |
sleeepyjack
reviewed
Jul 29, 2024
PointKernel
added
topic: static_map
Collaborator
|
/ok to test |
PointKernel
reviewed
Aug 1, 2024
sleeepyjack
approved these changes
Aug 2, 2024
sleeepyjack
left a comment
sleeepyjack
left a comment
Collaborator
There was a problem hiding this comment.
LGTM apart from the missing deallocate(tmp)
Member
With the first overload no longer desired by libcudf, shall we remove it from the current PR? |
Collaborator
|
@PointKernel the first overload was requested (or better proposed by me) in this thread (NV internal): https://nvidia.enterprise.slack.com/archives/CRJDZ0SKG/p1721975163922999 I think this overload is useful in general as it enables functionality similar to the |
Member
|
/ok to test |
PointKernel
reviewed
Aug 5, 2024
sleeepyjack
reviewed
Aug 6, 2024
Collaborator
|
/ok to test |
sleeepyjack
reviewed
Aug 8, 2024
Member
|
/ok to test |
bdice
reviewed
Aug 9, 2024
Member
|
/ok to test |
Member
|
/ok to test |
PointKernel
approved these changes
Aug 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two overloads of host-bulk
for_eachAPI for static_map.for_each(Callback callback_op)executes callback_op on every filled element in the map.
for_each(InputIt first, IntputIt last, CallbackOp callback_op)executes callback_op on every matched slot with key equals to a key from the input sequence.