Repository navigation
Use the new tuning API internally for detail::segmented_radix_sort::dispatch - #8927
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This comment has been minimized.
This comment has been minimized.
ea0103c to
41f97ab
Compare
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughimportant: Migrates segmented-radix-sort dispatch to derive policy from a tuning environment; public overloads forward the environment; benchmark updated to call DeviceSegmentedRadixSort::SortKeys; adds tuning tests that assert selected block sizes. ChangesSegmented Radix Sort Tuning API
Assessment against linked issues
Suggested reviewers
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: ba363737-cffc-471b-83a3-af69cfc27682
📒 Files selected for processing (4)
cub/benchmarks/bench/segmented_radix_sort/keys.cucub/cub/device/device_segmented_radix_sort.cuhcub/cub/device/dispatch/dispatch_segmented_radix_sort.cuhcub/test/catch2_test_device_segmented_radix_sort_env.cu
33dd692 to
0466d9a
Compare
| using offset_t = OffsetT; | ||
| using begin_offset_it_t = const offset_t*; | ||
| using end_offset_it_t = const offset_t*; | ||
| using segment_size_t = offset_t; |
There was a problem hiding this comment.
This causes the SASS diffs and I think the benchmark definition is wrong. The public API only allows a segment size type of int32.
0466d9a to
2e2fdeb
Compare
This comment has been minimized.
This comment has been minimized.
2e2fdeb to
4817007
Compare
🥳 CI Workflow Results🟩 Finished in 2h 31m: Pass: 100%/285 | Total: 3d 13h | Max: 59m 30s | Hits: 65%/329558See results here. |
detail::radix_sort::dispatch#7949cub.bench.segmented_radix_sort.keys.basefor SM75;80;90;100Fixes: #8926