Repository navigation
Add nonstable env DeviceSegmentedSort::Pairs 2/2 - #8286
Merged
Merged
Conversation
gonidelis
changed the title
DeviceSegmentedSort::Pairs
This comment has been minimized.
This comment has been minimized.
NaderAlAwar
reviewed
Apr 3, 2026
1 task done
gonidelis
changed the title
DeviceSegmentedSort::Pairs DeviceSegmentedSort::Pairs 2/2
5 of 20 tasks
This comment has been minimized.
This comment has been minimized.
NaderAlAwar
reviewed
Apr 8, 2026
Contributor
There was a problem hiding this comment.
Important: please add a custom-stream env test in this file, similar to the sibling env suites for segmented radix sort / merge sort (see
for example). The new cases here only passexpected_allocation_size(...), so they verify temp-storage plumbing but not that the launch-helper path / segmented sort dispatch actuallyhonors
cuda::get_stream_t. We still have stream-bearing examples in _env_api.cu, but those don’t give the same coverage as the helper-based env
Add SortPairs and SortPairsDescending env overloads for both pointer and DoubleBuffer variants. Each delegates to SortPairsNoNVTX<Order> via dispatch_with_env, matching the pattern from the stable overloads. Tests cover default env, custom stream propagation through the launch-helper path, allocation size verification, and env-based API examples with stream.sync() before assertions.
gonidelis
force-pushed
the
seg_sort_pairs_env_nonstable
branch
from
April 9, 2026 10:34
bcfbd9e to
1568074
Compare
Member
Author
|
I repushed all changes clean after refactoring that was done in #8003 with the current reviews incorporated. |
This comment has been minimized.
This comment has been minimized.
Comment on lines
+207
to
+208
| cudaStream_t custom_stream; | ||
| REQUIRE(cudaSuccess == cudaStreamCreate(&custom_stream)); |
Contributor
There was a problem hiding this comment.
Important: please use cuda::stream here for all the tests instead of the C APIs.
gonidelis
enabled auto-merge (squash)
April 14, 2026 00:56
Contributor
🥳 CI Workflow Results🟩 Finished in 1h 18m: Pass: 100%/269 | Total: 2d 17h | Max: 57m 03s | Hits: 98%/177321See results here. |
bernhardmgruber
approved these changes
Apr 14, 2026
jainishmehta
pushed a commit
to jainishmehta/cccl
that referenced
this pull request
Apr 19, 2026
* Add nonstable env overloads for DeviceSegmentedSort::SortPairs Add SortPairs and SortPairsDescending env overloads for both pointer and DoubleBuffer variants. Each delegates to SortPairsNoNVTX<Order> via dispatch_with_env, matching the pattern from the stable overloads. Tests cover default env, custom stream propagation through the launch-helper path, allocation size verification, and env-based API examples with stream.sync() before assertions. * Pass stream_ref directly and replace cudaStream_t with cuda::stream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split 2/2 from from #8003 for easier review