Repository navigation
Improve DeviceScan env test coverage and clean up stale code - #8280
Merged
Merged
Conversation
* Use non-identity init values so the init actually affects scan results * Use multi-element inputs so the scan op is exercised, not just init * Remove unused cudaGetDevice/PtxVersion calls, use ptx_arch_id instead
gonidelis
commented
Apr 2, 2026
This comment has been minimized.
This comment has been minimized.
gonidelis
commented
Apr 3, 2026
gonidelis
commented
Apr 3, 2026
gonidelis
commented
Apr 3, 2026
gonidelis
commented
Apr 3, 2026
gonidelis
commented
Apr 3, 2026
gonidelis
enabled auto-merge (squash)
April 7, 2026 14:35
This comment has been minimized.
This comment has been minimized.
bernhardmgruber
approved these changes
Apr 8, 2026
Contributor
🥳 CI Workflow Results🟩 Finished in 46m 12s: Pass: 100%/213 | Total: 2d 10h | Max: 31m 11s | Hits: 96%/124738See results here. |
gonidelis
added a commit
to gonidelis/cccl
that referenced
this pull request
Apr 8, 2026
…8280) * Use non-identity init values so the init actually affects scan results * Use multi-element inputs so the scan op is exercised, not just init * Remove unused cudaGetDevice/PtxVersion calls, use ptx_arch_id instead
jainishmehta
pushed a commit
to jainishmehta/cccl
that referenced
this pull request
Apr 19, 2026
…8280) * Use non-identity init values so the init actually affects scan results * Use multi-element inputs so the scan op is exercised, not just init * Remove unused cudaGetDevice/PtxVersion calls, use ptx_arch_id instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taking the opportunity from a recent review from one of my env PRs I took the liberty to clean up the scan tests mainly for two reasons:
initvalues to make sure they are factored in properlyexclusive*it's just theinitvalue) to make sure without loss of generality that the results is correct for the full input range and not just the edge caseblock_size_recording_iterator_tforExclusiveSumtuning test sinceExclusiveSumdoesn't accept a custom op, we use a custom input iterator that recordsblockDim.xas a side effect, allowing us to verify the tuning policy is appliedblockDim.xwrites inblock_size_check_twithif (threadIdx.x == 0)