Repository navigation
Add env overloads for DeviceSelect::FlaggedIf/Unique/UniqueByKey - #7794
Merged
Merged
Conversation
Contributor
gonidelis
force-pushed
the
select_env_unique
branch
from
February 25, 2026 19:41
f5415f6 to
d0c046c
Compare
gonidelis
marked this pull request as ready for review
February 25, 2026 19:42
gonidelis
changed the title
5 tasks done
gonidelis
force-pushed
the
select_env_unique
branch
3 times, most recently
from
February 25, 2026 20:31
d0c046c to
cff7edf
Compare
| typename EnvT = ::cuda::std::execution::env<>, | ||
| typename ::cuda::std::enable_if_t< | ||
| ::cuda::std::is_integral_v<NumItemsT> && !::cuda::std::is_same_v<KeyInputIteratorT, void*> | ||
| && !::cuda::std::is_convertible_v<EqualityOpT, cudaStream_t> |
Contributor
There was a problem hiding this comment.
Q: Is this check necessary?
Suggested change
| && !::cuda::std::is_convertible_v<EqualityOpT, cudaStream_t> |
What clash are we trying to prevent here? It should suffice in my understanding to just check that KeyInputIteratorT is not void* to distinguish the old overloads.
Edit: it made sense for the old overload set but not for the environment overloads. Please remove this check.
Member
Author
There was a problem hiding this comment.
no clash prevention. mere error check clarity. sfinae will give off a better error diagnostic here
cudaStream_t stream = ...;
cub::DeviceSelect::UniqueByKey(keys, vals, x, y, z, n, stream); compared to stream being wrongly deduced as EqualityOpT. I get that, it's on their user that just passed an argument in a completely wrong position but I don't see how it could hurt.
I removed it but let me know if you changed your mind and want to add it back @bernhardmgruber
NaderAlAwar
reviewed
Feb 25, 2026
This comment has been minimized.
This comment has been minimized.
gonidelis
force-pushed
the
select_env_unique
branch
from
February 26, 2026 00:48
1009e0d to
933f285
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bernhardmgruber
left a comment
bernhardmgruber
left a comment
Contributor
There was a problem hiding this comment.
We are still lacking an env-overload for DeviceSelect::FlaggedIf with IteratorT d_data, (the in-place version). Please add it.
gonidelis
force-pushed
the
select_env_unique
branch
from
March 5, 2026 20:22
933f285 to
983f57f
Compare
This comment has been minimized.
This comment has been minimized.
NaderAlAwar
reviewed
Mar 6, 2026
| //! The total number of items selected is written to ``d_num_selected_out``. | ||
| //! | ||
| //! .. versionadded:: 3.4.0 | ||
| //! First appears in CUDA Toolkit 12.4. |
Contributor
There was a problem hiding this comment.
Important:
Suggested change
| //! First appears in CUDA Toolkit 12.4. | |
| //! .. versionadded:: 3.4.0 | |
| //! First appears in CUDA Toolkit 13.4. |
| //! The total number of items selected is written to ``d_num_selected_out``. | ||
| //! | ||
| //! .. versionadded:: 3.4.0 | ||
| //! First appears in CUDA Toolkit 12.4. |
| //! The total number of items selected is written to ``d_num_selected_out``. | ||
| //! | ||
| //! .. versionadded:: 3.4.0 | ||
| //! First appears in CUDA Toolkit 12.4. |
gonidelis
force-pushed
the
select_env_unique
branch
from
March 9, 2026 20:28
983f57f to
24d1f89
Compare
Contributor
🥳 CI Workflow Results🟩 Finished in 2h 16m: Pass: 100%/249 | Total: 8d 13h | Max: 2h 15m | Hits: 73%/155761See results here. |
gonidelis
enabled auto-merge (squash)
March 10, 2026 03:18
NaderAlAwar
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds env based overloads for
DeviceSelect::FlaggedIfDeviceSelect::UniqueDeviceSelect::UniqueByKey(with customequality_opand without)Terminally closes #7552