Repository navigation
Use PDL in DeviceHistogram - #6367
Merged
Merged
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test 9ec444f |
This comment has been minimized.
This comment has been minimized.
miscco
reviewed
Oct 29, 2025
| _CCCL_PDL_GRID_DEPENDENCY_SYNC(); // TODO(bgruber): if we had the guarantee that there would be no pending | ||
| // writes/reads to the temp storage, we could omit the sync here | ||
|
|
||
| if (::cuda::std::reduce(num_output_bins_wrapper.begin(), num_output_bins_wrapper.end()) <= 2048) |
Contributor
There was a problem hiding this comment.
That looks like some arbitrary constraint. Is there a proper named constant for 2048?
Contributor
Author
There was a problem hiding this comment.
It seems you have seen a stale version of the PR. Refresh and enjoy a well named constant!
bernhardmgruber
force-pushed
the
pdl_hist
branch
from
October 31, 2025 19:20
9ec444f to
8ef7dfe
Compare
bernhardmgruber
marked this pull request as ready for review
October 31, 2025 19:20
This comment has been minimized.
This comment has been minimized.
bernhardmgruber
force-pushed
the
pdl_hist
branch
from
November 1, 2025 22:24
8ef7dfe to
862ef1e
Compare
This comment has been minimized.
This comment has been minimized.
bernhardmgruber
force-pushed
the
pdl_hist
branch
from
November 3, 2025 12:35
862ef1e to
ee4d8c6
Compare
bernhardmgruber
force-pushed
the
pdl_hist
branch
from
November 3, 2025 15:03
ee4d8c6 to
874c44a
Compare
Contributor
🥳 CI Workflow Results🟩 Finished in 4h 43m: Pass: 100%/86 | Total: 4d 11h | Max: 4h 23m | Hits: 66%/73464See results here. |
6 of 19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
agent_histogram.cuhPart 2 #6196cub.bench.histogram.even.basecub.bench.histogram.multi.even.baseOn the one run that regressed: I reran the benchmark and the regression went away, but other runs regressed a few percent again. It seems the results are not completely stable. I ran on node
6u1g-0010.