Repository navigation
Add environment overloads for DeviceTransform - #6204
Merged
Merged
Conversation
bernhardmgruber
force-pushed
the
env_transform
branch
from
October 13, 2025 13:52
f8103c9 to
1a9af9a
Compare
NaderAlAwar
reviewed
Oct 13, 2025
NaderAlAwar
approved these changes
Oct 13, 2025
bernhardmgruber
enabled auto-merge (squash)
October 13, 2025 14:30
This comment has been minimized.
This comment has been minimized.
Contributor
🥳 CI Workflow Results🟩 Finished in 3h 51m: Pass: 100%/75 | Total: 2d 02h | Max: 2h 21m | Hits: 75%/73732See results here. |
bernhardmgruber
added a commit
to bernhardmgruber/cccl
that referenced
this pull request
Jan 14, 2026
NVIDIA#6204 changed cub::DeviceTransform APIs from taking cudaStream_t to environments. Special handling preserved support for cudaStream_t. However, user-provided stream types with conversion operators to cudaStream_t were now queried as environments, failing to return a stream.
bernhardmgruber
added a commit
to bernhardmgruber/cccl
that referenced
this pull request
Jan 15, 2026
NVIDIA#6204 changed cub::DeviceTransform APIs from taking cudaStream_t to environments. Special handling preserved support for cudaStream_t. However, user-provided stream types with conversion operators to cudaStream_t were now queried as environments, failing to return a stream.
bernhardmgruber
added a commit
to bernhardmgruber/cccl
that referenced
this pull request
Jan 15, 2026
NVIDIA#6204 changed cub::DeviceTransform APIs from taking cudaStream_t to environments. Special handling preserved support for cudaStream_t. However, user-provided stream types with conversion operators to cudaStream_t were now queried as environments, failing to return a stream.
bernhardmgruber
added a commit
that referenced
this pull request
Jan 16, 2026
* Fix extracting CUDA stream in cub::DeviceTransform #6204 changed cub::DeviceTransform APIs from taking cudaStream_t to environments. Special handling preserved support for cudaStream_t. However, user-provided stream types with conversion operators to cudaStream_t were now queried as environments, failing to return a stream. * Properly use `get_stream` in device transform We should not have a special overload for the `get_stream` overload but should ensure that we can pass types that are convertible to `::cudaStream_t` and extract that stream I have expanded the get_stream CPO to accept a `::cudaStream_t __stream` so that we can work with those types Co-authored-by: Michael Schellenberger Costa <miscco@nvidia.com>
github-actions Bot
pushed a commit
that referenced
this pull request
Jan 16, 2026
* Fix extracting CUDA stream in cub::DeviceTransform #6204 changed cub::DeviceTransform APIs from taking cudaStream_t to environments. Special handling preserved support for cudaStream_t. However, user-provided stream types with conversion operators to cudaStream_t were now queried as environments, failing to return a stream. * Properly use `get_stream` in device transform We should not have a special overload for the `get_stream` overload but should ensure that we can pass types that are convertible to `::cudaStream_t` and extract that stream I have expanded the get_stream CPO to accept a `::cudaStream_t __stream` so that we can work with those types Co-authored-by: Michael Schellenberger Costa <miscco@nvidia.com> (cherry picked from commit 31f8a13)
bernhardmgruber
added a commit
that referenced
this pull request
Jan 16, 2026
…7263) * Fix extracting CUDA stream in cub::DeviceTransform #6204 changed cub::DeviceTransform APIs from taking cudaStream_t to environments. Special handling preserved support for cudaStream_t. However, user-provided stream types with conversion operators to cudaStream_t were now queried as environments, failing to return a stream. * Properly use `get_stream` in device transform We should not have a special overload for the `get_stream` overload but should ensure that we can pass types that are convertible to `::cudaStream_t` and extract that stream I have expanded the get_stream CPO to accept a `::cudaStream_t __stream` so that we can work with those types * Fix issue with `__query_or` * Avoid issue with `qury_or` CPO --------- Co-authored-by: Michael Schellenberger Costa <miscco@nvidia.com>
bernhardmgruber
added a commit
to bernhardmgruber/cccl
that referenced
this pull request
Mar 6, 2026
This is a fix for another bug introduced in NVIDIA#6204
bernhardmgruber
added a commit
to bernhardmgruber/cccl
that referenced
this pull request
Mar 6, 2026
This is a fix for another bug introduced in NVIDIA#6204
bernhardmgruber
added a commit
that referenced
this pull request
Mar 12, 2026
This is a fix for another bug introduced in #6204
bernhardmgruber
added a commit
to bernhardmgruber/cccl
that referenced
this pull request
Mar 12, 2026
This is a fix for another bug introduced in NVIDIA#6204
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #6203