Add Unique by Key Implementation for c.parallel by NaderAlAwar · Pull Request #3947 · NVIDIA/cccl

NaderAlAwar · 2025-02-26T16:12:02Z

Description

This should only be merged after #3816

Checklist

New or existing tests cover these changes.
The documentation is up to date with these changes.

…because this allows us to define it such that we can use the ActivePolicyT template parameter of invoke() as its policy, rather than the policy hub's MaxPolicy. ActivePolicyT will be the correct policy for the current ptx version, since calling invoke() from dispatch() causes us to move down the chained policies until we get to the correct one.

… needed because this allows us to define it such that we can use the ActivePolicyT template parameter of invoke() as its policy, rather than the policy hub's MaxPolicy. ActivePolicyT will be the correct policy for the current ptx version, since calling invoke() from dispatch() causes us to move down the chained policies until we get to the correct one." This reverts commit 2a17133.

…s it from the c.parallel layer. Also we don't need it to have any run-time state

…und an nvcc 12.0 template instantiation issue with vsmem_helper_fallback_policy_t

…aderalawar/cccl into unique-by-key-dynamic-dispatch

…rallel

…_key and fix issue with extra semicolon in kernel template instantiation

…rallel

shwina

Looks great to me - nice work, @NaderAlAwar!

github-actions · 2025-02-28T21:02:17Z

🟩 CI finished in 52m 15s: Pass: 100%/3 | Total: 1h 08m | Avg: 22m 56s | Max: 51m 53s | Hits: 97%/318

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 16m 57s | Avg: 8m 28s | Max: 14m 23s | Hits: 97%/318

🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total: 16m 57s | Avg:  8m 28s | Max: 14m 23s | Hits:  97%/318   
🟩 ctk
  🟩 12.8               Pass: 100%/2   | Total: 16m 57s | Avg:  8m 28s | Max: 14m 23s | Hits:  97%/318   
🟩 cudacxx
  🟩 nvcc12.8           Pass: 100%/2   | Total: 16m 57s | Avg:  8m 28s | Max: 14m 23s | Hits:  97%/318   
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/2   | Total: 16m 57s | Avg:  8m 28s | Max: 14m 23s | Hits:  97%/318   
🟩 cxx
  🟩 GCC13              Pass: 100%/2   | Total: 16m 57s | Avg:  8m 28s | Max: 14m 23s | Hits:  97%/318   
🟩 cxx_family
  🟩 GCC                Pass: 100%/2   | Total: 16m 57s | Avg:  8m 28s | Max: 14m 23s | Hits:  97%/318   
🟩 gpu
  🟩 rtx2080            Pass: 100%/2   | Total: 16m 57s | Avg:  8m 28s | Max: 14m 23s | Hits:  97%/318   
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  2m 34s | Avg:  2m 34s | Max:  2m 34s | Hits:  96%/159   
  🟩 Test               Pass: 100%/1   | Total: 14m 23s | Avg: 14m 23s | Max: 14m 23s | Hits:  98%/159

🟩 python: Pass: 100%/1 | Total: 51m 53s | Avg: 51m 53s | Max: 51m 53s

🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 51m 53s | Avg: 51m 53s | Max: 51m 53s
🟩 ctk
  🟩 12.8               Pass: 100%/1   | Total: 51m 53s | Avg: 51m 53s | Max: 51m 53s
🟩 cudacxx
  🟩 nvcc12.8           Pass: 100%/1   | Total: 51m 53s | Avg: 51m 53s | Max: 51m 53s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 51m 53s | Avg: 51m 53s | Max: 51m 53s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 51m 53s | Avg: 51m 53s | Max: 51m 53s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 51m 53s | Avg: 51m 53s | Max: 51m 53s
🟩 gpu
  🟩 rtx2080            Pass: 100%/1   | Total: 51m 53s | Avg: 51m 53s | Max: 51m 53s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 51m 53s | Avg: 51m 53s | Max: 51m 53s

👃 Inspect Changes

Modifications in project?

	Project
	CCCL Infrastructure
	libcu++
	CUB
	Thrust
	CUDA Experimental
	python
+/-	CCCL C Parallel Library
	Catch2Helper

Modifications in project or dependencies?

	Project
	CCCL Infrastructure
	libcu++
	CUB
	Thrust
	CUDA Experimental
+/-	python
+/-	CCCL C Parallel Library
	Catch2Helper

🏃‍ Runner counts (total jobs: 3)

#	Runner
2	`linux-amd64-gpu-rtx2080-latest-1`
1	`linux-amd64-cpu16`

gevtushenko · 2025-03-01T07:01:02Z

+  // TODO: we should update this once we figure out a way to reuse
+  // tuning logic from C++. Alternately, we should implement
+  // something better than a hardcoded default:
+  return {128, 10, cub::BLOCK_LOAD_DIRECT, cub::LOAD_DEFAULT};


important: we should wait with copy-pasting all the tuning policies we have on the C++ end until we have a machinery in place. That said, unique by key tuning uses items per thread scaling to better handle large data types. It shouldn't be a lot of effort to make the tuning policy depend on the key (similar to Nominal4BItemsToItems<KeyT>(10) logic) type along the lines of what we do in the reduce.cu. But if it's not the case, feel free to address this as a follow-up PR.

I had original implemented Nominal4BItemsToItems but that triggered the memory op assertion in the tests, so I overrode that value it produced with a smaller one. I moved Nominal4BItemsToItems to a common file to use it here, but I ran into the same issue, so I fixed it the same way. I think I'm just going to fix both in a later PR

Created #4013

github-actions · 2025-03-03T16:31:00Z

🟩 CI finished in 54m 47s: Pass: 100%/3 | Total: 1h 08m | Avg: 22m 43s | Max: 51m 15s | Hits: 98%/318

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 16m 55s | Avg: 8m 27s | Max: 14m 26s | Hits: 98%/318

🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total: 16m 55s | Avg:  8m 27s | Max: 14m 26s | Hits:  98%/318   
🟩 ctk
  🟩 12.8               Pass: 100%/2   | Total: 16m 55s | Avg:  8m 27s | Max: 14m 26s | Hits:  98%/318   
🟩 cudacxx
  🟩 nvcc12.8           Pass: 100%/2   | Total: 16m 55s | Avg:  8m 27s | Max: 14m 26s | Hits:  98%/318   
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/2   | Total: 16m 55s | Avg:  8m 27s | Max: 14m 26s | Hits:  98%/318   
🟩 cxx
  🟩 GCC13              Pass: 100%/2   | Total: 16m 55s | Avg:  8m 27s | Max: 14m 26s | Hits:  98%/318   
🟩 cxx_family
  🟩 GCC                Pass: 100%/2   | Total: 16m 55s | Avg:  8m 27s | Max: 14m 26s | Hits:  98%/318   
🟩 gpu
  🟩 rtx2080            Pass: 100%/2   | Total: 16m 55s | Avg:  8m 27s | Max: 14m 26s | Hits:  98%/318   
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  2m 29s | Avg:  2m 29s | Max:  2m 29s | Hits:  98%/159   
  🟩 Test               Pass: 100%/1   | Total: 14m 26s | Avg: 14m 26s | Max: 14m 26s | Hits:  98%/159

🟩 python: Pass: 100%/1 | Total: 51m 15s | Avg: 51m 15s | Max: 51m 15s

🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 51m 15s | Avg: 51m 15s | Max: 51m 15s
🟩 ctk
  🟩 12.8               Pass: 100%/1   | Total: 51m 15s | Avg: 51m 15s | Max: 51m 15s
🟩 cudacxx
  🟩 nvcc12.8           Pass: 100%/1   | Total: 51m 15s | Avg: 51m 15s | Max: 51m 15s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 51m 15s | Avg: 51m 15s | Max: 51m 15s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 51m 15s | Avg: 51m 15s | Max: 51m 15s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 51m 15s | Avg: 51m 15s | Max: 51m 15s
🟩 gpu
  🟩 rtx2080            Pass: 100%/1   | Total: 51m 15s | Avg: 51m 15s | Max: 51m 15s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 51m 15s | Avg: 51m 15s | Max: 51m 15s

👃 Inspect Changes

Modifications in project?

	Project
	CCCL Infrastructure
	libcu++
	CUB
	Thrust
	CUDA Experimental
	python
+/-	CCCL C Parallel Library
	Catch2Helper

Modifications in project or dependencies?

	Project
	CCCL Infrastructure
	libcu++
	CUB
	Thrust
	CUDA Experimental
+/-	python
+/-	CCCL C Parallel Library
	Catch2Helper

🏃‍ Runner counts (total jobs: 3)

#	Runner
2	`linux-amd64-gpu-rtx2080-latest-1`
1	`linux-amd64-cpu16`

…r unique by key

github-actions · 2025-03-04T01:38:41Z

🟩 CI finished in 50m 29s: Pass: 100%/3 | Total: 1h 07m | Avg: 22m 25s | Max: 50m 18s | Hits: 98%/320

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 16m 57s | Avg: 8m 28s | Max: 14m 26s | Hits: 98%/320

🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total: 16m 57s | Avg:  8m 28s | Max: 14m 26s | Hits:  98%/320   
🟩 ctk
  🟩 12.8               Pass: 100%/2   | Total: 16m 57s | Avg:  8m 28s | Max: 14m 26s | Hits:  98%/320   
🟩 cudacxx
  🟩 nvcc12.8           Pass: 100%/2   | Total: 16m 57s | Avg:  8m 28s | Max: 14m 26s | Hits:  98%/320   
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/2   | Total: 16m 57s | Avg:  8m 28s | Max: 14m 26s | Hits:  98%/320   
🟩 cxx
  🟩 GCC13              Pass: 100%/2   | Total: 16m 57s | Avg:  8m 28s | Max: 14m 26s | Hits:  98%/320   
🟩 cxx_family
  🟩 GCC                Pass: 100%/2   | Total: 16m 57s | Avg:  8m 28s | Max: 14m 26s | Hits:  98%/320   
🟩 gpu
  🟩 rtx2080            Pass: 100%/2   | Total: 16m 57s | Avg:  8m 28s | Max: 14m 26s | Hits:  98%/320   
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  2m 31s | Avg:  2m 31s | Max:  2m 31s | Hits:  98%/160   
  🟩 Test               Pass: 100%/1   | Total: 14m 26s | Avg: 14m 26s | Max: 14m 26s | Hits:  98%/160

🟩 python: Pass: 100%/1 | Total: 50m 18s | Avg: 50m 18s | Max: 50m 18s

🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 50m 18s | Avg: 50m 18s | Max: 50m 18s
🟩 ctk
  🟩 12.8               Pass: 100%/1   | Total: 50m 18s | Avg: 50m 18s | Max: 50m 18s
🟩 cudacxx
  🟩 nvcc12.8           Pass: 100%/1   | Total: 50m 18s | Avg: 50m 18s | Max: 50m 18s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 50m 18s | Avg: 50m 18s | Max: 50m 18s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 50m 18s | Avg: 50m 18s | Max: 50m 18s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 50m 18s | Avg: 50m 18s | Max: 50m 18s
🟩 gpu
  🟩 rtx2080            Pass: 100%/1   | Total: 50m 18s | Avg: 50m 18s | Max: 50m 18s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 50m 18s | Avg: 50m 18s | Max: 50m 18s

👃 Inspect Changes

Modifications in project?

	Project
	CCCL Infrastructure
	libcu++
	CUB
	Thrust
	CUDA Experimental
	python
+/-	CCCL C Parallel Library
	Catch2Helper

Modifications in project or dependencies?

	Project
	CCCL Infrastructure
	libcu++
	CUB
	Thrust
	CUDA Experimental
+/-	python
+/-	CCCL C Parallel Library
	Catch2Helper

🏃‍ Runner counts (total jobs: 3)

#	Runner
2	`linux-amd64-gpu-rtx2080-latest-1`
1	`linux-amd64-cpu16`

github-actions · 2025-03-05T01:08:52Z

🟩 CI finished in 1h 01m: Pass: 100%/3 | Total: 1h 14m | Avg: 24m 47s | Max: 57m 26s | Hits: 98%/320

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 16m 56s | Avg: 8m 28s | Max: 14m 26s | Hits: 98%/320

🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total: 16m 56s | Avg:  8m 28s | Max: 14m 26s | Hits:  98%/320   
🟩 ctk
  🟩 12.8               Pass: 100%/2   | Total: 16m 56s | Avg:  8m 28s | Max: 14m 26s | Hits:  98%/320   
🟩 cudacxx
  🟩 nvcc12.8           Pass: 100%/2   | Total: 16m 56s | Avg:  8m 28s | Max: 14m 26s | Hits:  98%/320   
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/2   | Total: 16m 56s | Avg:  8m 28s | Max: 14m 26s | Hits:  98%/320   
🟩 cxx
  🟩 GCC13              Pass: 100%/2   | Total: 16m 56s | Avg:  8m 28s | Max: 14m 26s | Hits:  98%/320   
🟩 cxx_family
  🟩 GCC                Pass: 100%/2   | Total: 16m 56s | Avg:  8m 28s | Max: 14m 26s | Hits:  98%/320   
🟩 gpu
  🟩 rtx2080            Pass: 100%/2   | Total: 16m 56s | Avg:  8m 28s | Max: 14m 26s | Hits:  98%/320   
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  2m 30s | Avg:  2m 30s | Max:  2m 30s | Hits:  97%/160   
  🟩 Test               Pass: 100%/1   | Total: 14m 26s | Avg: 14m 26s | Max: 14m 26s | Hits:  98%/160

🟩 python: Pass: 100%/1 | Total: 57m 26s | Avg: 57m 26s | Max: 57m 26s

🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 57m 26s | Avg: 57m 26s | Max: 57m 26s
🟩 ctk
  🟩 12.8               Pass: 100%/1   | Total: 57m 26s | Avg: 57m 26s | Max: 57m 26s
🟩 cudacxx
  🟩 nvcc12.8           Pass: 100%/1   | Total: 57m 26s | Avg: 57m 26s | Max: 57m 26s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 57m 26s | Avg: 57m 26s | Max: 57m 26s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 57m 26s | Avg: 57m 26s | Max: 57m 26s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 57m 26s | Avg: 57m 26s | Max: 57m 26s
🟩 gpu
  🟩 rtx2080            Pass: 100%/1   | Total: 57m 26s | Avg: 57m 26s | Max: 57m 26s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 57m 26s | Avg: 57m 26s | Max: 57m 26s

👃 Inspect Changes

Modifications in project?

	Project
	CCCL Infrastructure
	libcu++
	CUB
	Thrust
	CUDA Experimental
	python
+/-	CCCL C Parallel Library
	Catch2Helper

Modifications in project or dependencies?

	Project
	CCCL Infrastructure
	libcu++
	CUB
	Thrust
	CUDA Experimental
+/-	python
+/-	CCCL C Parallel Library
	Catch2Helper

🏃‍ Runner counts (total jobs: 3)

#	Runner
2	`linux-amd64-gpu-rtx2080-latest-1`
1	`linux-amd64-cpu16`

bernhardmgruber · 2025-03-07T10:30:27Z

@@ -0,0 +1,13 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of CUDA Experimental in CUDA C++ Core Libraries,


Is this correct? Isn't this the C parallel library?

I'm not really sure, this is the license used in the other files in the same directory

github-actions · 2025-03-07T15:36:05Z

🟩 CI finished in 53m 59s: Pass: 100%/3 | Total: 1h 07m | Avg: 22m 31s | Max: 50m 49s | Hits: 98%/320

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 16m 45s | Avg: 8m 22s | Max: 14m 23s | Hits: 98%/320

🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total: 16m 45s | Avg:  8m 22s | Max: 14m 23s | Hits:  98%/320   
🟩 ctk
  🟩 12.8               Pass: 100%/2   | Total: 16m 45s | Avg:  8m 22s | Max: 14m 23s | Hits:  98%/320   
🟩 cudacxx
  🟩 nvcc12.8           Pass: 100%/2   | Total: 16m 45s | Avg:  8m 22s | Max: 14m 23s | Hits:  98%/320   
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/2   | Total: 16m 45s | Avg:  8m 22s | Max: 14m 23s | Hits:  98%/320   
🟩 cxx
  🟩 GCC13              Pass: 100%/2   | Total: 16m 45s | Avg:  8m 22s | Max: 14m 23s | Hits:  98%/320   
🟩 cxx_family
  🟩 GCC                Pass: 100%/2   | Total: 16m 45s | Avg:  8m 22s | Max: 14m 23s | Hits:  98%/320   
🟩 gpu
  🟩 rtx2080            Pass: 100%/2   | Total: 16m 45s | Avg:  8m 22s | Max: 14m 23s | Hits:  98%/320   
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  2m 22s | Avg:  2m 22s | Max:  2m 22s | Hits:  98%/160   
  🟩 Test               Pass: 100%/1   | Total: 14m 23s | Avg: 14m 23s | Max: 14m 23s | Hits:  98%/160

🟩 python: Pass: 100%/1 | Total: 50m 49s | Avg: 50m 49s | Max: 50m 49s

🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 50m 49s | Avg: 50m 49s | Max: 50m 49s
🟩 ctk
  🟩 12.8               Pass: 100%/1   | Total: 50m 49s | Avg: 50m 49s | Max: 50m 49s
🟩 cudacxx
  🟩 nvcc12.8           Pass: 100%/1   | Total: 50m 49s | Avg: 50m 49s | Max: 50m 49s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 50m 49s | Avg: 50m 49s | Max: 50m 49s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 50m 49s | Avg: 50m 49s | Max: 50m 49s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 50m 49s | Avg: 50m 49s | Max: 50m 49s
🟩 gpu
  🟩 rtx2080            Pass: 100%/1   | Total: 50m 49s | Avg: 50m 49s | Max: 50m 49s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 50m 49s | Avg: 50m 49s | Max: 50m 49s

👃 Inspect Changes

Modifications in project?

	Project
	CCCL Infrastructure
	libcu++
	CUB
	Thrust
	CUDA Experimental
	python
+/-	CCCL C Parallel Library
	Catch2Helper

Modifications in project or dependencies?

	Project
	CCCL Infrastructure
	libcu++
	CUB
	Thrust
	CUDA Experimental
+/-	python
+/-	CCCL C Parallel Library
	Catch2Helper

🏃‍ Runner counts (total jobs: 3)

#	Runner
2	`linux-amd64-gpu-rtx2080-latest-1`
1	`linux-amd64-cpu16`

* Move nominal_4b_items_to_items to separate file for reuse * Use correct offset type for merge sort and unique by key

NaderAlAwar added 30 commits February 14, 2025 16:13

Move unique_by_key kernels to NVRTC compilable header

682bcd2

Add dynamic dispatch for unique_by_key

1d4e74f

Add missing host device qualifier

bc363a8

Fix issue where argument name was not changed

9704eb9

Merge branch 'main' into unique-by-key-dynamic-dispatch

3ac97f6

Forgot to rename local variable

00da18f

Remove old TODO comment

440716e

Add initial c.parallel implementation of building unique_by_key

240078d

Make vsmem_helper a template on the dispatch class so that we can pas…

5b210ec

…s it from the c.parallel layer. Also we don't need it to have any run-time state

Refactor how we instantiate vsmem_helper

dff4361

Pass VSMemHelper as template parameter to unique by key kernel

caed37f

Move the template parameters of VSMemHelper to its methods to workaro…

f37206b

…und an nvcc 12.0 template instantiation issue with vsmem_helper_fallback_policy_t

Make vsmem helper functions host device

d1c885c

Merge branch 'unique-by-key-dynamic-dispatch' of https://github.com/n…

666803b

…aderalawar/cccl into unique-by-key-dynamic-dispatch

Merge branch 'main' into unique-by-key-dynamic-dispatch

1ef5464

Remove unused macro

c6ef86f

Merge branch 'unique-by-key-dynamic-dispatch' into unique-by-key-c-pa…

e5bffb6

…rallel

Update unique_by_key c parallel implementation following recent changes

0d57ebd

Add tuning policies to c parallel unique_by_key

d7d7928

Make KeyT and ValueT templates for DispatchUniqueByKey

4d0372c

Merge branch 'unique-by-key-dynamic-dispatch' into unique-by-key-c-pa…

b37f88a

…rallel

Add first c parallel unique_by_key test

131a8a9

Make vsmem helper methods static

c653ce2

Move scan_tile_state to separate source file to reuse it in unique_by…

e666a57

…_key and fix issue with extra semicolon in kernel template instantiation

Add more tests for unique_by_key

1ed7a3d

Fix SFINAE for UniqueByKeyPolicyWrapper

895852d

Merge branch 'unique-by-key-dynamic-dispatch' into unique-by-key-c-pa…

6bde2ab

…rallel

Fix checking output in unique_by_key test

18aaae2

NaderAlAwar requested a review from shwina February 28, 2025 20:08

shwina approved these changes Feb 28, 2025

View reviewed changes

NaderAlAwar requested a review from oleksandr-pavlyk February 28, 2025 21:03

gevtushenko reviewed Mar 1, 2025

View reviewed changes

NaderAlAwar added 2 commits March 3, 2025 15:14

Use pointer_t subscript operator directly

b030447

Make unique by key output iterator test transform values

b5649b8

NaderAlAwar added 8 commits March 3, 2025 16:35

Fix issue where num selected was not working as an output iterator fo…

e81a68f

…r unique by key

Remove unused tuning code

86bb2b9

Refactor common iterator creation code into test_util.h

8ef44c8

Remove unnecessary calls to nvrtcGetTypeName

0791311

Remove unused iterator

55dc4fd

Move nominal_4b_items_to_items to separate file for reuse

1efe612

Use correct offset type for merge sort and unique by key

511dfd0

Use correct type for delay constructor

8699984

NaderAlAwar requested a review from gevtushenko March 4, 2025 00:48

Use appropriate offset types for merge sort and unique by key

7c8fd3d

gevtushenko approved these changes Mar 7, 2025

View reviewed changes

bernhardmgruber reviewed Mar 7, 2025

View reviewed changes

Use clamp() instead of min + max

7c4df05

NaderAlAwar enabled auto-merge (squash) March 7, 2025 15:35

NaderAlAwar merged commit 84889c6 into NVIDIA:main Mar 7, 2025

github-project-automation Bot moved this from In Review to Done in CCCL Mar 7, 2025

NaderAlAwar mentioned this pull request Mar 11, 2025

Add transform c parallel implementation #4048

Merged

2 tasks

davebayer pushed a commit to davebayer/cccl that referenced this pull request Mar 12, 2025

Add Unique by Key Implementation for c.parallel (NVIDIA#3947)

347f0ef

* Move nominal_4b_items_to_items to separate file for reuse * Use correct offset type for merge sort and unique by key

davebayer pushed a commit to davebayer/cccl that referenced this pull request Apr 7, 2025

Add Unique by Key Implementation for c.parallel (NVIDIA#3947)

3da7f4a

* Move nominal_4b_items_to_items to separate file for reuse * Use correct offset type for merge sort and unique by key

Conversation

NaderAlAwar commented Feb 26, 2025

Description

Checklist

Uh oh!

shwina left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Feb 28, 2025

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 16m 57s | Avg: 8m 28s | Max: 14m 23s | Hits: 97%/318

🟩 python: Pass: 100%/1 | Total: 51m 53s | Avg: 51m 53s | Max: 51m 53s

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 3)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gevtushenko Mar 1, 2025

Choose a reason for hiding this comment

Uh oh!

NaderAlAwar Mar 4, 2025

Choose a reason for hiding this comment

Uh oh!

NaderAlAwar Mar 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Mar 3, 2025

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 16m 55s | Avg: 8m 27s | Max: 14m 26s | Hits: 98%/318

🟩 python: Pass: 100%/1 | Total: 51m 15s | Avg: 51m 15s | Max: 51m 15s

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 3)

Uh oh!

github-actions Bot commented Mar 4, 2025

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 16m 57s | Avg: 8m 28s | Max: 14m 26s | Hits: 98%/320

🟩 python: Pass: 100%/1 | Total: 50m 18s | Avg: 50m 18s | Max: 50m 18s

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 3)

Uh oh!

github-actions Bot commented Mar 5, 2025

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 16m 56s | Avg: 8m 28s | Max: 14m 26s | Hits: 98%/320

🟩 python: Pass: 100%/1 | Total: 57m 26s | Avg: 57m 26s | Max: 57m 26s

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 3)

Uh oh!

bernhardmgruber Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

NaderAlAwar Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Mar 7, 2025

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 16m 45s | Avg: 8m 22s | Max: 14m 23s | Hits: 98%/320

🟩 python: Pass: 100%/1 | Total: 50m 49s | Avg: 50m 49s | Max: 50m 49s

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 3)

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development