Repository navigation
[cudax][cuco] Replace __index_type with size_t and drop __distance - #12584
Draft
PointKernel wants to merge 6 commits into
Draft
PointKernel wants to merge 6 commits into
PointKernel wants to merge 6 commits into
Conversation
PointKernel
added
cudax
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Member
Author
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
Member
Author
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
Member
Author
|
/ok to test |
Contributor
🥳 CI Workflow Results🟩 Finished in 1h 18m: Pass: 100%/75 | Total: 16h 31m | Max: 1h 18m | Hits: 58%/83627See results here. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #12511.
This PR replaces
detail::__index_typewithcuda::std::size_tfor input-range lengths and thread/element indices in the cuco bulk kernels and bloom filter loops, and dropsdetail::__distance, which also removes the__int128narrowing that #12505 hits.Checklist