Repository navigation
[CUB] Extract shared numeric and scan reference test helpers - #12260
bernhardmgruber merged 1 commit into
Conversation
Move numeric utilities and CPU scan reference functions into dedicated headers for reuse by segmented-scan tests. Update the existing scan and reduce test headers to include them without changing test behavior. This is preparatory PR with no behavior changes for subsequent change to segmented-scan tests to use cuda buffers
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Numeric helpers and reduction test header cub/test/catch2_test_numeric_helpers.cuh, cub/test/catch2_test_device_reduce.cuh |
The new header defines extended-float operations, iterator and operator unwrapping, and default-value initialization. The reduction test header includes it and removes local helper functions, reference calculations, and type declarations. |
Scan reference functions cub/test/catch2_test_scan_reference.cuh, cub/test/catch2_test_device_scan.cuh |
The new header defines exclusive and inclusive scan reference calculations. The scan test header includes it and removes its local definitions. By-key reference helpers remain in the scan test header. |
Possibly related PRs
- NVIDIA/cccl#11374: Its segmented-scan tests use shared type and reference-helper patterns related to the reusable helpers added here.
Suggested reviewers: gonidelis
Priority:
Change: Refactor
Merge Risk: 
Minimal · up to ed4c4
-
The helper extraction has no substantiated behavior or build regression; it is ready for normal merge checks.
Comment @coderabbitai help to get the list of available commands.
Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
-
- Commit to this branch
- Create a new PR
🥳 CI Workflow Results🟩 Finished in 1h 50m: Pass: 100%/137 | Total: 2d 13h | Max: 1h 50m | Hits: 71%/194137See results here. |
| @@ -0,0 +1,149 @@ | |||
| // SPDX-FileCopyrightText: Copyright (c) 2023, NVIDIA CORPORATION. All rights reserved. | |||
There was a problem hiding this comment.
Q: Is it correct to keep the old date here? Not sure since the code was only moved and not touched.
miscco
left a comment
There was a problem hiding this comment.
I am fine with keeping the old date
Move numeric utilities and CPU scan reference functions into dedicated headers for reuse by segmented-scan tests. Update the existing scan and reduce test headers to include them without changing test behavior.
This is preparatory PR with no behavior changes for subsequent change to segmented-scan tests to use cuda buffers
This PR provides a focused subset of changes from #11374
Checklist