Repository navigation
Refactor C2H headers by responsibility - #11338
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe change splits C2H testing, memory, environment, and generator code into dedicated headers. Public generator APIs move to ChangesC2H header refactor
Assessment against linked issues
Out-of-scope changes
Suggested reviewers: Priority: ➖ Normal Change: Refactor Merge Risk: ⚪ Minimal · up to The header-only refactor has no identified merge-blocking risk. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 366d9dd1-bf1e-474a-b763-f7d44039f8eb
📒 Files selected for processing (10)
c2h/include/c2h/catch2_test_helper.hc2h/include/c2h/checked_allocator.cuhc2h/include/c2h/detail/catch2_nvtx.hc2h/include/c2h/detail/catch2_seed.hc2h/include/c2h/detail/checked_memory.cuhc2h/include/c2h/detail/env.cuhc2h/include/c2h/detail/generators.cuhc2h/include/c2h/generator_types.hc2h/include/c2h/generators.hc2h/include/c2h/vector_generators.h
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.
- Clamps the configured limit to physical memory. - Safely calculates unavailable memory. - Saturates adjusted free memory at zero.
962f49c to
d09fb7f
Compare
This comment has been minimized.
This comment has been minimized.
🥳 CI Workflow Results🟩 Finished in 2h 22m: Pass: 100%/61 | Total: 1d 14h | Max: 2h 22m | Hits: 62%/104816See results here. |
* Refactor C2H headers by responsibility * catch2_nvtx.h to use namespace c2h::detail namespace over namespace detail * use const qualifier for override_str read-only variable * Use saturating arithmetic for the overridden free-memory calculation - Clamps the configured limit to physical memory. - Safely calculates unavailable memory. - Saturates adjusted free memory at zero. * generator_types.h -> generator_common.h
* Refactor C2H headers by responsibility * catch2_nvtx.h to use namespace c2h::detail namespace over namespace detail * use const qualifier for override_str read-only variable * Use saturating arithmetic for the overridden free-memory calculation - Clamps the configured limit to physical memory. - Safely calculates unavailable memory. - Saturates adjusted free memory at zero. * generator_types.h -> generator_common.h
Description
This PR is the first in the sequence of more focused chunks comprising #10898
It splits c2h headers into parts to prepare ground for use of
cuda::bufferwith checked allocators analogous to what is used byc2h::device_vectorandc2h::host_vector.closes #11337
Checklist