Skip to content

Correct test_segmented_reduce.py::test_segmented_reduce #4197

Closed

Description

@oleksandr-pavlyk

The test is meant to create partition of input array into random-size segments, call segmented_reduce and verify against sequential calls to sum over segments.

The test does not correctly form offsets associated with such partition. It samples random sizes from multinomial distribution, but fails to scan over these sizes, hence producing a sequence which is not guaranteed to be non-decreasing.

The test should be modified to perform meaningful acceptance testing.

Activity

  1. added a commit that references this issue on Mar 19, 2025
    143c6b0
  2. moved this from Todo to In Review in CCCLon Mar 19, 2025
  3. moved this from In Review to Done in CCCLon Mar 24, 2025
  4. added a commit that references this issue on Mar 25, 2025
    7ea0812
  5. added 2 commits that reference this issue on Mar 25, 2025
    661a335
    3783746
  6. added 2 commits that reference this issue on Apr 7, 2025
    63567bc
    db8ef8a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    • Status
      Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions