Repository navigation

[None][feat] Enable NCCL_SYMMETRIC as default fallback for AllReduce - #9314

Merged

Tabrizian merged 35 commits into

NVIDIA:mainfrom

nv-lschneider:lschneider/default-nccl-symmetric

Dec 7, 2025

Merged

[None][feat] Enable NCCL_SYMMETRIC as default fallback for AllReduce#9314
Tabrizian merged 35 commits into
NVIDIA:mainfrom
nv-lschneider:lschneider/default-nccl-symmetric

Commits on Dec 4, 2025
- adding a new nccl window buffer manager that goes with the lifetime of the nccl communicator
  nv-lschneider
  committed
  bcfc5e7
- namespace for test fixing
  nv-lschneider
  committed
  a801e29
- linking stuff for tests
  nv-lschneider
  committed
  0a37759
- moving NCCL helper
  nv-lschneider
  committed
  71c5f27
- using new NCCL util
  nv-lschneider
  committed
  3a00d39
- remove NCCLUBAllocator
  nv-lschneider
  committed
  8f92df4
- Changing default strategy to NCCL_SYMMETRIC
  nv-lschneider
  committed
  005b299
- cleaning up and adding tests before PR
  nv-lschneider
  committed
  869fe5b
- fixing python tests
  nv-lschneider
  committed
  6faa5ae
- fixing problems
  nv-lschneider
  committed
  0bdd976
- test hardeing
  nv-lschneider
  committed
  e5ab0e6
- redesign tests
  nv-lschneider
  committed
  773c0e5
- one test after the other
  nv-lschneider
  committed
  ec851a9
- one test after the other
  nv-lschneider
  committed
  8f1f69a
- asdf
  nv-lschneider
  committed
  6ce2b69
- updating test
  nv-lschneider
  committed
  c91f468
- fixing test pickling
  nv-lschneider
  committed
  ac10eca
- wrapping
  nv-lschneider
  committed
  8565156
- fix remaining tests
  nv-lschneider
  committed
  2886a79
- adding simple arithmetic to the test
  nv-lschneider
  committed
  1dc7b28
- add AR to the test
  nv-lschneider
  committed
  bc07a49
- rename test sensibly
  nv-lschneider
  committed
  cb863ac
- addressing coderabbit
  nv-lschneider
  committed
  1450363
- more code rabbit comments
  nv-lschneider
  committed
  684f623
- fixes
  nv-lschneider
  committed
  ed59495
- addressing review comments
  nv-lschneider
  committed
  d38942d
- adding empirical model explanation
  nv-lschneider
  committed
  5096fe3
- removing ncclWindowTensor python interface
  nv-lschneider
  committed
  a8b0b85
- registering the new test for CI
  nv-lschneider
  committed
  fe95686
- removing ncclWindowTensor from build system
  nv-lschneider
  committed
  e184326
- querying MNNVL to determine if it is worth it to copy data
  nv-lschneider
  committed
  0ee6a9b
- fixes
  nv-lschneider
  committed
  6903bd8
- cosmetic fixes
  nv-lschneider
  committed
  1677026
- fix functional to include NCCL_SYMMETRIC workspace, to fix test
  nv-lschneider
  committed
  d91623f
- treating NCCL_SYMMETRIC like NCCL
  nv-lschneider
  committed
  38a9c5d

Commits

Commits on Dec 4, 2025