Repository navigation
[None][feat] Add opt-in submitted-operation timeouts for native KV transfers - #21950
Draft
chienchunhung wants to merge 1 commit into
Draft
chienchunhung wants to merge 1 commit into
chienchunhung wants to merge 1 commit into
Conversation
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Collaborator
Author
|
/bot run --disable-fail-fast |
Collaborator
|
PR_Github #83582 [ run ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #83582 [ run ] completed with state
|
Draft
1 task done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Existing KV-transfer deadlines include readiness and queue waiting; they do not provide an independent limit for a backend-accepted operation. Add a default-off submitted-operation timeout while preserving existing wait budgets and physical-resource retirement rules.
Scope
kv_transfer_operation_timeout_ms, limited to the Python transceiver's qualified no-retry, generation-first FP4 MLA ownership profile; startup validation rejects unsupported profiles and inconsistent executor-rank budgets.IN_DOUBTretention and late settlement; expiry closes subsequent sender submission, and late completion does not clear that poison, so an aggressive budget can require executor recovery.Verification
Draft head:
695e9bba704a1626131b85c89eebd4c5229c84a1(base6fc7f47a322d88037ffe9eca6913526f1f05a4fb). This draft is incomplete and not ready for approval.git diff --check, Python 3.13 syntax checks, applicable pre-commit checks and DCO checks passed. The advisory Pyrefly hook did not execute type checking because Pyrefly is unavailable.tensorrt_llm/usage/llm_args_golden_manifest.jsonandtensorrt_llm/schemas/*.jsonin a matching runtime before this PR is ready. They have not been hand-edited or waived.Targeted verification (still required):
Notes
Related #21734 adds a separate request-wide deadline; this PR targets
mainand does not reset or replace that budget. The new configuration field requires telemetry/privacy CODEOWNER approval. A tracking issue has not yet been assigned.