Repository navigation
Conversation
Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
Signed-off-by: tburt-nv <195370667+tburt-nv@users.noreply.github.com>
|
/bot skip --comment "waive only" |
|
Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements. |
|
No actionable comments were generated in the recent review. WalkthroughThree DGX_H100 context-first BF16 tests were added to the integration skip list. Each entry references NVBug 7051902. The existing allreduce-strategy accuracy test remains skipped. ChangesIntegration test waivers
Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Suggested reviewers: Merge Risk:
|
|
PR_Github #83120 [ skip ] triggered by Bot. Commit: |
|
PR_Github #83120 [ skip ] completed with state |
Description
Temporarily waive 1 failed case(s) on
DGX_H100. Opened automatically by auto-waive (draft; a human reviews and merges).The native main-break detector (
native-p3/k3-w12h-fresh12h-nopass-hostclock/1.0.1) reportsdisaggregated/test_disaggregated.py::test_disaggregated_context_first_bf16_ownershipbroken on main for DGX_H100: failure signatureruntimeerror: # worker(s) exited during startup: /path (rc=#), onset 2026-11-05T04:51:24Z, latest failure 2026-11-05T15:11:01Z. Policynative_p3@1.0.0selected it; https://nvbugs/7051902 tracks the fix. ScopeDGX_H100is the stage prefix that ran the failing test.Tests in this break event:
disaggregated/test_disaggregated.py::test_disaggregated_context_first_bf16_ownershipon DGX_H100PRs whose pre-merge runs hit this break (rebase or re-run after this merges):
What to check before merging:
DGX_H100matches the failing stage and no narrower waiver already exists.Provenance
native-p3/k3-w12h-fresh12h-nopass-hostclock/1.0.1, policynative_p3@1.0.0b2679f67-9e1c-407e-a303-e337949777f9; snapshot SHA-256bf238dc37a1a674c5920684005308a7cfad7e1619c5a98e0bcd30b6d049c4109; config SHA-25609cf0ee078a35cefbb2080f3d321976a2a18bc5d6e6c6b3de9d637db1c92730bdisaggregated/test_disaggregated.py::test_disaggregated_context_first_bf16_ownership: incident56dc2aaef48f7e991ea73fdf1f7bc58747d9c2f8150d33576171428b4d322727, observation52a0254ac0d92e812907a61a60a09743caa9982e5ea7671f5e5c83a51a4d6960Test Coverage
Review the incident evidence and selector scope before merging. This proposal does not
establish that main is fixed. Confirm restoration separately after the corrective change.
PR Checklist
Dev Engineer Review
tests/integration/test_lists/waives.txtadds threeDGX_H100skip entries associated with NVBug 7051902. The entries cover one disaggregated integration test and two unit tests. This is a test-selection change; it does not fix the underlying behavior. Remove the waivers after the bug is fixed and the tests pass.QA Engineer Review
The waiver list adds these test IDs:
test_disaggregated_context_first_bf16_ownership,test_context_first_bf16_owned_transfer, andtest_context_first_bf16_lifecycle_gpu. All three entries use thefull:DGX_H100selector and reference NVBug 7051902. The change skips these tests; it does not provide test results or verify a fix. Coverage verdict: needs follow-up.Per-File QA Perspective
tests/integration/test_lists/waives.txt: Adds threeDGX_H100waivers for disaggregated ownership, KV transfer, and transfer lifecycle tests. Confirm the waivers are removed after the bug is fixed and the tests pass.