Repository navigation
[None][feat] Mooncake safe shared-pool reuse and asynchronous loading - #21656
Draft
SimengLiu-nv wants to merge 1 commit into
Draft
SimengLiu-nv wants to merge 1 commit into
SimengLiu-nv wants to merge 1 commit into
Conversation
1 task done
This was referenced Nov 4, 2026
Closed
SimengLiu-nv
force-pushed
the
codex/pr21195-mooncake
branch
2 times, most recently
from
November 4, 2026 20:14
8c97925 to
fa14298
Compare
Collaborator
Author
|
/bot run --disable-fail-fast |
Collaborator
|
PR_Github #82583 [ run ] triggered by Bot. Commit: |
Enable safe shared-pool KV reuse and optional asynchronous loading in the Mooncake store connector. Signed-off-by: Simeng Liu <simengl@nvidia.com>
SimengLiu-nv
force-pushed
the
codex/pr21195-mooncake
branch
from
November 4, 2026 23:10
fa14298 to
064b081
Compare
Collaborator
|
PR_Github #82583 [ run ] completed with state
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@coderabbitai summary
Description
Enable safe shared-pool KV reuse and optional asynchronous loading in the Mooncake store connector.
Asynchronous loading remains off by default. Upgrade guidance requires draining old writers and resetting affected pool contents because unchanged keys cannot identify previously published invalid KV.
Dependency: #21655; the current diff includes its unmerged runtime changes.
Test Coverage
The Mooncake connector, common, settings, and real-pool suites cover publication, recovery, key compatibility, speculative reuse, startup gates, eviction options, staging, and asynchronous load lifecycle.
test_llm_api_connector_mooncake.pycovers model-level reuse, including attention-DP consumers.PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.