[farazkh80]

Summary

release/1.3 counterpart of #20057 (requested in #20057 (comment)): remove the https://nvbugs/6811958 waiver for unittest/usage/test_llmapi_config_telemetry_docs.py::test_build_capture_manifest_matches_committed_golden.

On release/1.3 the golden manifest is already current — the uses_spcompress regeneration (#19493, landed via 129655f) is on the branch and none of the later main-only drift (#19811, #20100) was ever cherry-picked — so only the waiver line needs to go. Not a cherry-pick of #20057 because that PR also carries main-only manifest rows.

Test Coverage

CPU-only on release/1.3 tip:

• python3 scripts/generate_llm_args_golden_manifest.py → no diff
• pytest tests/unittest/usage/test_llmapi_config_telemetry_docs.py → 19 passed

Covered in CI by l0_cpu.yml (unittest/usage).

PR Checklist

• PR title follows the required format
• PR description explains what and why
• Test coverage listed
• Related documentation N/A
• Confirmed CODING_GUIDELINES.md and no large files / secrets

Dev Engineer Review

The change removes one waiver for NVBUG 6811958. No source or configuration changes are included. The supplied PR context reports that the release branch’s golden manifest is current and that the author validated it with manifest generation and the telemetry documentation test. I could not independently verify those results.

QA Engineer Review

The change removes the waiver for unittest/usage/test_llmapi_config_telemetry_docs.py::test_build_capture_manifest_matches_committed_golden from tests/integration/test_lists/waives.txt. This enables the test to run instead of being skipped. The supplied context identifies l0_cpu.yml as CI coverage. Coverage verdict: needs follow-up because no current CI result was supplied.

Per-File QA Perspective

• tests/integration/test_lists/waives.txt: Removes the waiver for the committed golden manifest test. QA should verify that the test runs in the applicable CI job and passes against the release/1.3 manifest.

[farazkh80]

/bot run

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: NVIDIA/TensorRT-LLM/.coderabbit.yaml
• Review profile: CHILL
• Plan: Enterprise
• Run ID: 99c47d62-6439-4040-a655-dcb6ecde6702

📥 Commits

Reviewing files that changed from the base of the PR and between 42ca6ba and 155e7f4.

📒 Files selected for processing: 1

• tests/integration/test_lists/waives.txt

💤 Files with no reviewable changes: 1

• tests/integration/test_lists/waives.txt

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

The integration skip list no longer contains the waiver entry for the telemetry documentation test associated with NVBUG 6811958.

Changes

Telemetry test waiver

Layer / File(s)	Summary
Remove telemetry test waiver tests/integration/test_lists/waives.txt	The skip-list entry for the telemetry documentation test is removed.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 155e7

No actionable issue is identified with removing the waiver. Merge after normal checks.

Pre-merge checks: 5

Passed checks: 5 passed

Check name	Status	Explanation
Title check		The title follows the required ticket and type format and clearly identifies the main change: removing the waiver for the specified test.
Description check		The description explains the release branch context, the reason for removing the waiver, the affected test, and the validation results. It includes test coverage and a completed checklist.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[tensorrt-cicd]

PR_Github #78137 [ run ] triggered by Bot. Commit: 155e7f4 Link to invocation

[tensorrt-cicd]

PR_Github #78137 [ run ] completed with state FAILURE. Commit: 155e7f4
/LLM/release-1.3/L0_MergeRequest_PR pipeline #258 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

• Please check the failed tests and fix your PR
• If you cannot view the failures, ask the CI triggerer to share details
• Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

[farazkh80]

/bot run

[tensorrt-cicd]

PR_Github #78190 [ run ] triggered by Bot. Commit: 155e7f4 Link to invocation

[tensorrt-cicd]

PR_Github #78190 [ run ] completed with state SUCCESS. Commit: 155e7f4
/LLM/release-1.3/L0_MergeRequest_PR pipeline #266 completed with status: 'SUCCESS'

CI Report

Link to invocation

[farazkh80]

/bot run

[github-actions]

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental) --high-priority]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Supports wildcard * for pattern matching (e.g., "*PerfSanity*" matches all stages containing PerfSanity). Examples: "A10-PyTorch-1, xxx", "PerfSanity". The patterns "*", "*Post-Merge*", and "*PerfSanity*", including equivalent escaped or repeated-star forms and their use in comma-separated lists, require the ci: post-merge approved PR label. Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Requires the ci: full pre-merge approved label on the PR (ask a member of NVIDIA/trt-llm-ci-approvers). Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline. Requires the ci: full pre-merge approved label on the PR (ask a member of NVIDIA/trt-llm-ci-approvers).

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline. Requires the ci: post-merge approved PR label applied by an active member of NVIDIA/trt-llm-ci-approvers. The approval label remains in place when new commits are pushed.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Supports wildcard * for pattern matching. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx", --extra-stage "Post-Merge". The patterns "*", "*Post-Merge*", and "*PerfSanity*", including equivalent escaped or repeated-star forms and their use in comma-separated lists, require the ci: post-merge approved PR label.

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

--high-priority (OPTIONAL) : Run the pipeline with high priority. This option is restricted to authorized users only and will route the job to a high-priority queue.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

[brnguyen2]

Approving as the correct release/1.3 counterpart of #20057 (not a straight cherry-pick, as the description notes). Verified against the branch:

• The removed waiver line is byte-identical to the one on release/1.3 tip.
• The manifest row #20057 adds (sparse_attention_config.gvr_deterministic_topk) is correctly omitted here: that field does not exist anywhere on release/1.3, so the committed golden manifest is already current and only the waiver removal applies.

Change is a correctly-scoped, low-risk waiver removal. Note blossom-ci is still pending at review time; the green test rests on the author's local run until it reports.

[github-actions]

Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements.

[tensorrt-cicd]

PR_Github #78223 [ run ] triggered by Bot. Commit: 14f76b7 Link to invocation

[tensorrt-cicd]

PR_Github #78223 [ run ] completed with state SUCCESS. Commit: 14f76b7
/LLM/release-1.3/L0_MergeRequest_PR pipeline #268 completed with status: 'SUCCESS'

CI Report

Link to invocation