Repository navigation
[https://nvbugs/6345827][test] Unwaive DeepSeekV3Lite disagg MTP test_auto_dtype on H20 and H100 - #20351
Conversation
…_auto_dtype on H20 and H100 (NVIDIA#19958) Signed-off-by: Michal Guzek <mguzek@nvidia.com>
|
/bot run --disable-fail-fast --extra-stage "DGX_H200-8_GPUs-PyTorch-Post-Merge-1" |
|
PR_Github #77925 [ run ] triggered by Bot. Commit: |
|
PR_Github #77925 [ run ] completed with state
|
|
/bot run --extra-stage "DGX_H200-8_GPUs-PyTorch-Post-Merge-1" |
|
PR_Github #79586 [ run ] triggered by Bot. Commit: |
|
PR_Github #79586 [ run ] completed with state
|
|
Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements. |
|
/bot run --extra-stage "DGX_H200-8_GPUs-PyTorch-Post-Merge-1" |
|
PR_Github #79694 [ run ] triggered by Bot. Commit: |
|
PR_Github #79694 [ run ] completed with state |
Description
Cherry-pick of #19958 (merged to
mainascc63e66daf) torelease/1.3.accuracy/test_disaggregated_serving.py::TestDeepSeekV3Lite::test_auto_dtype[mtp_nextn=2-overlap_scheduler={False,True}]hung in the QA run on H20 at 53b392e (last pass db7161b) and was waived asfull:H20/...(nvbugs/6345827, #15510). The same two cases on H100 were waived the same week (#15504) under nvbugs/6313072, which tracks an unrelated OOM in the aggregatedTestDeepSeekV3Lite::test_bfloat16and has since been verified fixed and closed. Neither GPU has run the two disaggregated cases since; in L0 the test only runs onDGX_H200-8_GPUs-PyTorch-Post-Merge-1.At the time the test used
backend: DEFAULT, i.e. the C++ transceiver over UCX. The failing run's teardown log shows the generation ranks blocked incheckGenTransferStatus->future.get()on transfers whose KV data the context side never sent (gen rank 3 still mid-recvon one request while ranks 0-2 had already received it), with all 16 in-flight requests (the harness'smax_workers=16) stuck behind it until the pytest timeout. This is consistent with theCacheSenderlost-wakeup race:removeResponse()checkedmReadyResponses.empty()outside the lock and then clearedmAnyReady, which could overwrite a concurrentsendAsync()and leave the responder asleep with a ready response queued; once every in-flight request is waiting on generation, no furthersendAsync()arrives to wake it. That race was fixed by #15737 (nvbugs/6342844), and since #17090 the test uses the Python transceiver (NIXL), so it no longer exercises that path at all.This PR removes the four stale QA waives (H20 and H100).
Test Coverage
qa/llm_function_core.txt):TestDeepSeekV3Lite::test_auto_dtype[mtp_nextn=2-overlap_scheduler=False]and[mtp_nextn=2-overlap_scheduler=True].72688933d5:test_auto_dtype[mtp_nextn=2-overlap_scheduler=False]: PASSED (MMLU 71.37, GSM8K 64.48)test_auto_dtype[mtp_nextn=2-overlap_scheduler=True]: PASSED (MMLU 71.37, GSM8K 64.94)DGX_H200-8_GPUs-PyTorch-Post-Merge-1has passed both cases on everymainpost-merge run since 2026-07-10 and on everyrelease/1.3post-merge run that reached them (onerelease/1.3build failed the whole stage in setup onpip install opencv-python-headless); QA B200/B300 pass all fourtest_auto_dtypevariants; QA H20 passes themtp_nextn=0variants.PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.Dev Engineer Review
tests/integration/test_lists/waives.txtremoves four waivers forTestDeepSeekV3Lite::test_auto_dtypewithmtp_nextn=2, covering both overlap-scheduler settings on H20 and H100. No source or API changes are reported. The PR states that these waivers are stale because the implicated race was fixed and the test now uses the Python transceiver; other waivers remain.QA Engineer Review
Only a test-list file changed. The four
mtp_nextn=2cases are no longer skipped on H20 and H100. The cases appear intests/integration/test_lists/qa/llm_function_core.txtandllm_function_rtx6k.txt; the H200 CI list includes both cases intests/integration/test_lists/test-db/l0_dgx_h200.yml. The PR reports passing local H200 and CI runs, but H20 and H100 confirmation is pending. Coverage verdict: needs follow-up.Per-File QA Perspective
tests/integration/test_lists/waives.txt: Removes the four H20/H100 waiver entries for the twomtp_nextn=2selector variants. QA should confirm both variants pass on H20 and H100.