[None][test] Exclude Inductor subproc threads from integration threadleak check by HuiGao-NV · Pull Request #20294 · NVIDIA/TensorRT-LLM

HuiGao-NV · 2026-10-14T13:34:48Z

This is a fix for a flaky test failure.

Dev Engineer Review

The pytest configuration now excludes InductorSubproc, InductorSubprocHealth, and subproc_worker_timer from thread-leak checks. This targets the flaky integration check, but it also means leaks from threads with these names will not be reported. No test results were provided.

QA Engineer Review

tests/integration/defs/pytest.ini changed. The update modifies the thread-leak exclusion pattern; it does not add or change test functions, IDs, selectors, or waivers. No test-list change is shown. Coverage verdict: needs follow-up because no test results were provided.

Per-File QA Perspective

tests/integration/defs/pytest.ini: The configuration suppresses thread-leak reports for three Inductor-related thread names. Verify that the intended integration test no longer fails and that the exclusions do not hide unrelated thread leaks.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

HuiGao-NV · 2026-10-14T13:35:16Z

/bot run --disable-fail-fast

coderabbitai · 2026-10-14T13:41:37Z

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

Configuration used: Repository: NVIDIA/TensorRT-LLM/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 89925e6e-c663-4f5f-8dcd-77a89fc5f904

📥 Commits

Reviewing files that changed from the base of the PR and between 2c65502 and 1c7a61a.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: NVIDIA/TensorRT-LLM/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: d5fd6498-bdcf-4f92-a567-d15f37072053

📥 Commits

Reviewing files that changed from the base of the PR and between 91404de and cc431c0.

📒 Files selected for processing: 1

tests/integration/defs/pytest.ini

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

The pytest thread-leak exclusions now include patterns for InductorSubproc, InductorSubprocHealth, and subproc_worker_timer.

Changes

Thread-leak exclusions

Layer / File(s)	Summary
Update pytest exclusion patterns `tests/integration/defs/pytest.ini`	The exclusion list adds the `InductorSubproc`, `InductorSubprocHealth`, and `subproc_worker_timer` thread-name patterns.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to cc431

The configuration change is mergeable; no actionable leak-detection regression was found.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Description check		The description states that the change fixes a flaky test failure, but it does not explain the solution, identify the affected test, or provide test coverage. The required description and Test Coverag…	Add a concise explanation of the flaky failure and the `threadleak_exclude` change. List the relevant test or validation performed, and complete any applicable checklist items.

Passed checks: 4 passed

Check name	Status	Explanation
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Title check		The title clearly identifies the test change: excluding Inductor sub-process threads from the integration thread-leak check. It follows the required ticket and type format.

Full details: Description check

Explanation

The description states that the change fixes a flaky test failure, but it does not explain the solution, identify the affected test, or provide test coverage. The required description and Test Coverage sections remain incomplete.

✨ Finishing Touches: 💡 1

🛠️ Fix failing CI checks: 💡

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

tensorrt-cicd · 2026-10-14T13:43:41Z

PR_Github #77819 [ run ] triggered by Bot. Commit: cc431c0 Link to invocation

tensorrt-cicd · 2026-10-14T17:35:09Z

PR_Github #77819 [ run ] completed with state SUCCESS. Commit: cc431c0
/LLM/main/L0_MergeRequest_PR pipeline #64151 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

github-actions · 2026-10-15T00:24:51Z

Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements.

HuiGao-NV · 2026-10-15T05:06:09Z

/bot run --stage-list "CPU-Generic-arm-1,A10-PyTorch-1,CPU-Generic-x86-1"

tensorrt-cicd · 2026-10-15T05:12:38Z

PR_Github #78012 [ run ] triggered by Bot. Commit: 2c65502 Link to invocation

tensorrt-cicd · 2026-10-15T08:34:50Z

PR_Github #78012 [ run ] completed with state FAILURE. Commit: 2c65502
/LLM/main/L0_MergeRequest_PR pipeline #64309 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

HuiGao-NV · 2026-10-15T09:19:01Z

/bot run --stage-list "CPU-Generic-arm-1,A10-PyTorch-1,CPU-Generic-x86-1"

tensorrt-cicd · 2026-10-15T09:25:46Z

PR_Github #78089 [ run ] triggered by Bot. Commit: 2c65502 Link to invocation

tensorrt-cicd · 2026-10-15T10:33:51Z

PR_Github #78089 [ run ] completed with state FAILURE. Commit: 2c65502
/LLM/main/L0_MergeRequest_PR pipeline #64365 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

…leak check Signed-off-by: HuiGao <huig@nvidia.com>

HuiGao-NV · 2026-10-15T22:54:40Z

/bot run --disable-fail-fast

tensorrt-cicd · 2026-10-15T23:00:52Z

PR_Github #78246 [ run ] triggered by Bot. Commit: 1c7a61a Link to invocation

tensorrt-cicd · 2026-10-16T03:16:41Z

PR_Github #78246 [ run ] completed with state FAILURE. Commit: 1c7a61a
/LLM/main/L0_MergeRequest_PR pipeline #64494 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

HuiGao-NV · 2026-10-16T04:29:55Z

/bot run

tensorrt-cicd · 2026-10-16T04:36:16Z

PR_Github #78351 [ run ] triggered by Bot. Commit: 1c7a61a Link to invocation

tensorrt-cicd · 2026-10-16T06:48:41Z

PR_Github #78351 [ run ] completed with state SUCCESS. Commit: 1c7a61a
/LLM/main/L0_MergeRequest_PR pipeline #64582 completed with status: 'SUCCESS'

CI Report

Link to invocation

…ccuracy test Both parametrizations of test_rebalance_matches_baseline were waived because pytest-threadleak flagged Inductor compile-worker threads that the test's torch.compile'd logprob path starts in-process. NVIDIA#20294 added those thread names to the integration threadleak_exclude, so the test passes again and the waivers can go. Signed-off-by: Thor Johnsen <41591019+thorjohnsen@users.noreply.github.com>

HuiGao-NV requested review from a team as code owners October 14, 2026 13:34

HuiGao-NV requested review from BowenFu, brnguyen2, dpitman-nvda, hanjingtian and jieli-matrix October 14, 2026 13:34

github-actions Bot assigned HuiGao-NV Oct 14, 2026

BowenFu approved these changes Oct 15, 2026

View reviewed changes

trtllm-agent added the ci: full pre-merge approved label Oct 15, 2026

HuiGao-NV force-pushed the add_excluded_threadleak branch from cc431c0 to 2c65502 Compare October 15, 2026 04:59

HuiGao-NV enabled auto-merge (squash) October 15, 2026 09:19

chenfeiz0326 mentioned this pull request Oct 15, 2026

[https://nvbugs/6919428][fix] Keep DeepSeek-V4 TP decode all-reduces off NCCL #20233

Merged

1 task done

[None][test] Exclude Inductor subproc threads from integration thread…

1c7a61a

…leak check Signed-off-by: HuiGao <huig@nvidia.com>

HuiGao-NV force-pushed the add_excluded_threadleak branch from 2c65502 to 1c7a61a Compare October 15, 2026 22:54

jieli-matrix approved these changes Oct 16, 2026

View reviewed changes

HuiGao-NV merged commit 6544bcd into NVIDIA:main Oct 16, 2026

Conversation

HuiGao-NV commented Oct 14, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Dev Engineer Review

QA Engineer Review

Per-File QA Perspective

Description

Test Coverage

PR Checklist

GitHub Bot Help

Uh oh!

HuiGao-NV commented Oct 14, 2026

Uh oh!

coderabbitai Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Uh oh!

tensorrt-cicd commented Oct 14, 2026

Uh oh!

tensorrt-cicd commented Oct 14, 2026

Uh oh!

github-actions Bot commented Oct 15, 2026

Uh oh!

HuiGao-NV commented Oct 15, 2026

Uh oh!

tensorrt-cicd commented Oct 15, 2026

Uh oh!

tensorrt-cicd commented Oct 15, 2026

Uh oh!

HuiGao-NV commented Oct 15, 2026

Uh oh!

tensorrt-cicd commented Oct 15, 2026

Uh oh!

tensorrt-cicd commented Oct 15, 2026

Uh oh!

HuiGao-NV commented Oct 15, 2026

Uh oh!

tensorrt-cicd commented Oct 15, 2026

Uh oh!

tensorrt-cicd commented Oct 16, 2026

Uh oh!

HuiGao-NV commented Oct 16, 2026

Uh oh!

tensorrt-cicd commented Oct 16, 2026

Uh oh!

tensorrt-cicd commented Oct 16, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

HuiGao-NV commented Oct 14, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Oct 14, 2026 •

edited

Loading